Fixed bug #867 : Squiz.Strings.DoubleQuoteUsage broken for some escape codes

Author: gsherwood

CodeSniffer/Standards/Squiz/Sniffs/Strings/DoubleQuoteUsageSniff.php

@@ -103,13 +103,22 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
 
         $allowedChars = array(
                          '\0',
+                         '\1',
+                         '\2',
+                         '\3',
+                         '\4',
+                         '\5',
+                         '\6',
+                         '\7',
                          '\n',
                          '\r',
                          '\f',
                          '\t',
                          '\v',
                          '\x',
                          '\b',
+                         '\e',
+                         '\u',
                          '\'',
                         );
 

CodeSniffer/Standards/Squiz/Tests/Strings/DoubleQuoteUsageUnitTest.inc

@@ -23,5 +23,7 @@ there";
 $string = 'Hello
 there';
 
+$string = "\123 \234"."\u123"."\e";
+
 echo "window.location = \"".$url."\";\n";
-echo ""
+echo ""

CodeSniffer/Standards/Squiz/Tests/Strings/DoubleQuoteUsageUnitTest.inc.fixed

@@ -23,5 +23,7 @@ there';
 $string = 'Hello
 there';
 
+$string = "\123 \234"."\u123"."\e";
+
 echo 'window.location = "'.$url."\";\n";
-echo ''
+echo ''

CodeSniffer/Standards/Squiz/Tests/Strings/DoubleQuoteUsageUnitTest.php

@@ -52,8 +52,8 @@ public function getErrorList()
                 18 => 1,
                 19 => 1,
                 21 => 1,
-                26 => 1,
-                27 => 1,
+                28 => 1,
+                29 => 1,
                );
 
     }//end getErrorList()

package.xml

@@ -61,6 +61,8 @@ http://pear.php.net/dtd/package-2.0.xsd">
   - Fixed bug #857 : PSR2.ControlStructure.SwitchDeclaration shouldn't check indent of curly brace closers
   - Fixed bug #859 : Switch statement indention issue when returning function call with closure
   - Fixed bug #861 : Single-line arrays and function calls can generate incorrect indentation errors
+  - Fixed bug #867 : Squiz.Strings.DoubleQuoteUsage broken for some escape codes
+    -- Thanks to Jack Blower for the help with the fix
   - Fixed bug #21005 : Incorrect indent detection when multiple properties are initialized to arrays
   - Fixed bug #21010 : Incorrect missing colon detection in CSS when first style is not on new line
   - Fixed bug #21011 : Incorrect error message text when newline found after opening brace