Skip to content

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Dec 10, 2025

Motivation

Appending a bytes array to a StringBuilder doesn't make sense. Code was added in #23347.
This issue found with errorprone.

Modifications

  • fix issue by calling encodeToString on Base64 encoder

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Converting bytes array to a String doesn't make sense.
Issue found with errorprone
@lhotari lhotari added this to the 4.2.0 milestone Dec 10, 2025
@lhotari lhotari self-assigned this Dec 10, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 10, 2025
@lhotari lhotari changed the title Fix output of --print-metadata in cli consume [fix][cli] Fix output of --print-metadata in cli consume Dec 10, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.33%. Comparing base (89f6015) to head (395223e).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...g/apache/pulsar/client/cli/AbstractCmdConsume.java 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #25056       +/-   ##
=============================================
+ Coverage     38.64%   74.33%   +35.68%     
- Complexity    13341    34111    +20770     
=============================================
  Files          1864     1921       +57     
  Lines        146223   150387     +4164     
  Branches      16984    17470      +486     
=============================================
+ Hits          56506   111784    +55278     
+ Misses        82051    29689    -52362     
- Partials       7666     8914     +1248     
Flag Coverage Δ
inttests 26.37% <0.00%> (-0.07%) ⬇️
systests 22.85% <0.00%> (-0.04%) ⬇️
unittests 73.87% <0.00%> (+39.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...g/apache/pulsar/client/cli/AbstractCmdConsume.java 16.39% <0.00%> (+16.39%) ⬆️

... and 1421 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Technoboy- Technoboy- merged commit 0244536 into apache:master Dec 10, 2025
57 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants