Skip to content

Conversation

@hezhizhen
Copy link
Contributor

Change Summary

Problem:
HTTP block headers were being lost during parsing. The frontend stores headers as a JSON string, but the backend only supported object format.

Solution:
Modified from_document to support both string and object formats.

Motivation and details

Any additional details about the changes you made, such as why you made them, what problems they solve, and how they work.

Tasks

  • Regenerated TS-RS bindings (if any ts(export) structs have changed)
  • Updated the documentation in docs/ (if any application behavior has changed)
  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle

@greptile-apps
Copy link

greptile-apps bot commented Dec 10, 2025

Greptile Overview

Greptile Summary

Fixed HTTP block header parsing to handle both JSON string format (from frontend) and object format (for backward compatibility).

  • Added parsing logic to detect and handle headers as JSON strings
  • Maintained backward compatibility with object format
  • Added test coverage for string-format headers

Important Files Changed

File Analysis

Filename Score Overview
crates/atuin-desktop-runtime/src/blocks/http.rs 5/5 Fixed header parsing to support both JSON string and object formats from frontend

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! really appreciate the fix <3

@ellie ellie merged commit 3fcd619 into atuinsh:main Dec 11, 2025
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants