feat: add image list and rm commands #400
Conversation
billyb2
requested review from
alexisbouchez,
Copilot,
goller,
ischolten,
jacobwgillespie,
lukevmorris and
nagypeterjob
There was a problem hiding this comment.
Pull Request Overview
This PR implements image registry management commands for the Depot CLI, adding functionality to list and remove container images from the registry.
- Defines Protocol Buffer service definitions for registry image operations with pagination support
- Implements interactive and non-interactive image listing with multiple output formats
- Adds batch image deletion functionality with confirmation prompts
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| proto/depot/build/v1/registry.proto | Protocol Buffer definitions for RegistryService with ListImages and DeleteImage RPCs |
| pkg/proto/depot/build/v1/registry.pb.go | Generated Go code from protobuf definitions |
| pkg/proto/depot/build/v1/buildv1connect/registry.connect.go | Generated Connect-RPC client and server interfaces |
| pkg/cmd/root/root.go | Registers new image command in CLI root |
| pkg/cmd/image/image.go | Main image command with subcommands |
| pkg/cmd/image/list.go | Image listing command with interactive table and CSV/JSON output |
| pkg/cmd/image/rm.go | Image removal command with batch deletion support |
| pkg/api/rpc.go | Adds registry client factory function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| ctx := cmd.Context() | ||
|
|
||
| projectID = helpers.ResolveProjectID(projectID) |
There was a problem hiding this comment.
Bug: Missing CWD Argument Causes Compilation Error
The helpers.ResolveProjectID call in pkg/cmd/image/rm.go is missing the cwd argument. This differs from its usage in pkg/cmd/image/list.go and will cause a compilation error, preventing proper project ID resolution from local configuration.
Additional Locations (1)
billyb2
removed request for
alexisbouchez,
goller,
ischolten,
jacobwgillespie,
lukevmorris and
nagypeterjob
|
Putting this in draft to write tests |
|
ran some manual tests, everything seems to have ran well! |
No description provided.