Fix #35105: Continue analysis in ESLint mode despite suppressions

- Modified tryCompileFunction to differentiate between ESLint mode and build mode
- In ESLint mode (noEmit: true): Log suppressions but continue compilation
- In build mode (noEmit: false): Maintain existing behavior (skip on suppression)
- Added 4 test fixtures with snapshots to verify the fix
- Fixes issue where eslint-disable comments prevented incompatible-library warnings

Author: manNomi

compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Program.ts

@@ -719,8 +719,10 @@ function tryCompileFunction(
      * See: https://github.com/facebook/react/issues/35105
      */
     if (!programContext.opts.noEmit) {
-      // Build mode: maintain existing behavior
-      // If suppressions exist, skip compilation entirely
+      /*
+       * Build mode: maintain existing behavior
+       * If suppressions exist, skip compilation entirely
+       */
       return {
         kind: 'error',
         error: suppressionsToCompilerError(suppressionsInFunction),

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/error.build-mode-with-suppression-skips-compilation.expect.md

@@ -0,0 +1,46 @@
+
+## Input
+
+```javascript
+// Build mode (no @noEmit) - should skip compilation when suppressions exist
+import {useEffect, useState} from 'react';
+
+function Component() {
+  const [count, setCount] = useState(0);
+
+  useEffect(() => {
+    console.log(count);
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, []);
+
+  return <div>{count}</div>;
+}
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [],
+};
+
+```
+
+
+## Error
+
+```
+Found 1 error:
+
+Error: React Compiler has skipped optimizing this component because one or more React ESLint rules were disabled
+
+React Compiler only works when your components follow all the rules of React, disabling them may result in unexpected or incorrect behavior. Found suppression `eslint-disable-next-line react-hooks/exhaustive-deps`.
+
+error.build-mode-with-suppression-skips-compilation.ts:9:4
+   7 |   useEffect(() => {
+   8 |     console.log(count);
+>  9 |     // eslint-disable-next-line react-hooks/exhaustive-deps
+     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Found React rule suppression
+  10 |   }, []);
+  11 |
+  12 |   return <div>{count}</div>;
+```
+          
+      

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/error.build-mode-with-suppression-skips-compilation.js

@@ -1,19 +1,18 @@
 // Build mode (no @noEmit) - should skip compilation when suppressions exist
-import { useEffect, useState } from 'react';
+import {useEffect, useState} from 'react';
 
 function Component() {
   const [count, setCount] = useState(0);
-  
+
   useEffect(() => {
     console.log(count);
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);
-  
+
   return <div>{count}</div>;
 }
 
 export const FIXTURE_ENTRYPOINT = {
   fn: Component,
   params: [],
 };
-

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/eslint-mode-detects-incompatible-library-with-suppression.expect.md

@@ -0,0 +1,66 @@
+
+## Input
+
+```javascript
+// @noEmit
+import {useEffect} from 'react';
+
+// Simulating an incompatible library API
+function useVirtualizer(config) {
+  return {scrollToIndex: () => {}};
+}
+
+function MyHook() {
+  const virtualizer = useVirtualizer({
+    count: 100,
+    getScrollElement: () => null,
+    estimateSize: () => 35,
+  });
+
+  useEffect(() => {
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, []);
+
+  return virtualizer;
+}
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: MyHook,
+  params: [],
+};
+
+```
+
+## Code
+
+```javascript
+// @noEmit
+import { useEffect } from "react";
+
+// Simulating an incompatible library API
+function useVirtualizer(config) {
+  return { scrollToIndex: () => {} };
+}
+
+function MyHook() {
+  const virtualizer = useVirtualizer({
+    count: 100,
+    getScrollElement: () => null,
+    estimateSize: () => 35,
+  });
+
+  useEffect(() => {
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, []);
+  return virtualizer;
+}
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: MyHook,
+  params: [],
+};
+
+```
+      
+### Eval output
+(kind: ok) {"scrollToIndex":"[[ function params=0 ]]"}

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/eslint-mode-detects-incompatible-library-with-suppression.js

@@ -1,9 +1,9 @@
 // @noEmit
-import { useEffect } from 'react';
+import {useEffect} from 'react';
 
 // Simulating an incompatible library API
 function useVirtualizer(config) {
-  return { scrollToIndex: () => {} };
+  return {scrollToIndex: () => {}};
 }
 
 function MyHook() {
@@ -12,16 +12,15 @@ function MyHook() {
     getScrollElement: () => null,
     estimateSize: () => 35,
   });
-  
+
   useEffect(() => {
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);
-  
+
   return virtualizer;
 }
 
 export const FIXTURE_ENTRYPOINT = {
   fn: MyHook,
   params: [],
 };
-

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/eslint-mode-multiple-suppressions-continues-analysis.expect.md

@@ -0,0 +1,68 @@
+
+## Input
+
+```javascript
+// @noEmit
+import {useEffect, useState} from 'react';
+
+function Component() {
+  const [x, setX] = useState(0);
+
+  // eslint-disable-next-line react-hooks/exhaustive-deps
+  useEffect(() => {
+    console.log('First effect');
+  }, []);
+
+  // eslint-disable-next-line react-hooks/exhaustive-deps
+  useEffect(() => {
+    console.log('Second effect');
+  }, []);
+
+  // eslint-disable-next-line no-console
+  console.log('test');
+
+  return <div>{x}</div>;
+}
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [],
+};
+
+```
+
+## Code
+
+```javascript
+// @noEmit
+import { useEffect, useState } from "react";
+
+function Component() {
+  const [x, setX] = useState(0);
+
+  // eslint-disable-next-line react-hooks/exhaustive-deps
+  useEffect(() => {
+    console.log("First effect");
+  }, []);
+
+  // eslint-disable-next-line react-hooks/exhaustive-deps
+  useEffect(() => {
+    console.log("Second effect");
+  }, []);
+
+  // eslint-disable-next-line no-console
+  console.log("test");
+
+  return <div>{x}</div>;
+}
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [],
+};
+
+```
+      
+### Eval output
+(kind: ok) <div>0</div>
+logs: ['test','First effect','Second effect']

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/eslint-mode-multiple-suppressions-continues-analysis.js

@@ -1,22 +1,22 @@
 // @noEmit
-import { useEffect, useState } from 'react';
+import {useEffect, useState} from 'react';
 
 function Component() {
   const [x, setX] = useState(0);
-  
+
   // eslint-disable-next-line react-hooks/exhaustive-deps
   useEffect(() => {
     console.log('First effect');
   }, []);
-  
+
   // eslint-disable-next-line react-hooks/exhaustive-deps
   useEffect(() => {
     console.log('Second effect');
   }, []);
-  
+
   // eslint-disable-next-line no-console
   console.log('test');
-  
+
   return <div>{x}</div>;
 }
 

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/eslint-mode-with-suppression-continues-analysis.expect.md

@@ -0,0 +1,54 @@
+
+## Input
+
+```javascript
+// @noEmit
+import {useEffect, useState} from 'react';
+
+function Component() {
+  const [count, setCount] = useState(0);
+
+  useEffect(() => {
+    console.log(count);
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, []);
+
+  const result = count * 2;
+  return <div>{result}</div>;
+}
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [],
+};
+
+```
+
+## Code
+
+```javascript
+// @noEmit
+import { useEffect, useState } from "react";
+
+function Component() {
+  const [count, setCount] = useState(0);
+
+  useEffect(() => {
+    console.log(count);
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, []);
+
+  const result = count * 2;
+  return <div>{result}</div>;
+}
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [],
+};
+
+```
+      
+### Eval output
+(kind: ok) <div>0</div>
+logs: [0]

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/eslint-mode-with-suppression-continues-analysis.js

@@ -1,14 +1,14 @@
 // @noEmit
-import { useEffect, useState } from 'react';
+import {useEffect, useState} from 'react';
 
 function Component() {
   const [count, setCount] = useState(0);
-  
+
   useEffect(() => {
     console.log(count);
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);
-  
+
   const result = count * 2;
   return <div>{result}</div>;
 }
@@ -17,4 +17,3 @@ export const FIXTURE_ENTRYPOINT = {
   fn: Component,
   params: [],
 };
-