Skip to content

Commit 6b15148

Browse files
authored
Merge branch 'develop' into cg-JS-1207
2 parents 076c4df + e9b2df9 commit 6b15148

File tree

291 files changed

+2782
-665
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

291 files changed

+2782
-665
lines changed

.craft.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@ preReleaseCommand: bash scripts/craft-pre-release.sh
44
targets:
55
# NPM Targets
66
## 1. Base Packages, node or browser SDKs depend on
7-
## 1.1 Types
8-
- name: npm
9-
id: '@sentry/types'
10-
includeNames: /^sentry-types-\d.*\.tgz$/
11-
## 1.2 Core SDKs
7+
## 1.1 Core SDKs
128
- name: npm
139
id: '@sentry/core'
1410
includeNames: /^sentry-core-\d.*\.tgz$/
11+
## 1.2 Types
12+
- name: npm
13+
id: '@sentry/types'
14+
includeNames: /^sentry-types-\d.*\.tgz$/
1515
- name: npm
1616
id: '@sentry/node-core'
1717
includeNames: /^sentry-node-core-\d.*\.tgz$/

.cursor/BUGBOT.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,3 +45,16 @@ Do not flag the issues below if they appear in tests.
4545
convention as the `SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN` value.
4646
- When calling `startSpan`, check if error cases are handled. If flag that it might make sense to try/catch and call `captureException`.
4747
- When calling `generateInstrumentationOnce`, the passed in name MUST match the name of the integration that uses it. If there are more than one instrumentations, they need to follow the pattern `${INSTRUMENTATION_NAME}.some-suffix`.
48+
49+
## Testing Conventions
50+
51+
- When reviewing a `feat` PR, check if the PR includes at least one integration or E2E test.
52+
If neither of the two are present, add a comment, recommending to add one.
53+
- When reviewing a `fix` PR, check if the PR includes at least one unit, integration or e2e test that tests the regression this PR fixes.
54+
Usually this means the test failed prior to the fix and passes with the fix.
55+
If no tests are present, add a comment recommending to add one.
56+
- Check that tests actually test the newly added behaviour.
57+
For instance, when checking on sent payloads by the SDK, ensure that the newly added data is asserted thoroughly.
58+
- Flag usage of `expect.objectContaining` and other relaxed assertions, when a test expects something NOT to be included in a payload but there's no respective assertion.
59+
- Flag usage of conditionals in one test and recommend splitting up the test for the different paths.
60+
- Flag usage of loops testing multiple scenarios in one test and recommend using `(it)|(test).each` instead.

.github/workflows/auto-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
steps:
1616
- name: Get auth token
1717
id: token
18-
uses: actions/create-github-app-token@67018539274d69449ef7c02e8e71183d1719ab42 # v2.1.4
18+
uses: actions/create-github-app-token@7e473efe3cb98aa54f8d4bac15400b15fad77d94 # v2.2.0
1919
with:
2020
app-id: ${{ vars.SENTRY_RELEASE_BOT_CLIENT_ID }}
2121
private-key: ${{ secrets.SENTRY_RELEASE_BOT_PRIVATE_KEY }}

.github/workflows/build.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -992,6 +992,8 @@ jobs:
992992
working-directory: ${{ runner.temp }}/test-application
993993
timeout-minutes: 7
994994
run: ${{ matrix.build-command || 'pnpm test:build' }}
995+
env:
996+
SENTRY_E2E_WORKSPACE_ROOT: ${{ github.workspace }}
995997

996998
- name: Install Playwright
997999
uses: ./.github/actions/install-playwright
@@ -1003,6 +1005,8 @@ jobs:
10031005
working-directory: ${{ runner.temp }}/test-application
10041006
timeout-minutes: 10
10051007
run: ${{ matrix.assert-command || 'pnpm test:assert' }}
1008+
env:
1009+
SENTRY_E2E_WORKSPACE_ROOT: ${{ github.workspace }}
10061010

10071011
- name: Upload Playwright Traces
10081012
uses: actions/upload-artifact@v5

.github/workflows/create-issue-for-unreferenced-prs.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,14 @@ jobs:
4141
return;
4242
}
4343
44+
// Bail if this edit was made by the GitHub Actions bot (this workflow)
45+
// This prevents infinite loops when we update the PR body with the new issue reference
46+
// We check login specifically to not skip edits from other legitimate bots
47+
if (context.payload.sender && context.payload.sender.login === 'github-actions[bot]') {
48+
console.log(`PR #${pr.number} was edited by github-actions[bot] (this workflow), skipping.`);
49+
return;
50+
}
51+
4452
// Check if the PR is already approved
4553
const reviewsResponse = await github.rest.pulls.listReviews({
4654
owner: context.repo.owner,
@@ -109,7 +117,7 @@ jobs:
109117
console.log(`Created issue #${issueID}.`);
110118
111119
// Update the PR body to reference the new issue
112-
const updatedPrBody = `${prBody}\n\nCloses #${issueID}`;
120+
const updatedPrBody = `${prBody}\n\nCloses #${issueID} (added automatically)`;
113121
114122
await github.rest.pulls.update({
115123
owner: context.repo.owner,

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
steps:
2020
- name: Get auth token
2121
id: token
22-
uses: actions/create-github-app-token@67018539274d69449ef7c02e8e71183d1719ab42 # v2.1.4
22+
uses: actions/create-github-app-token@7e473efe3cb98aa54f8d4bac15400b15fad77d94 # v2.2.0
2323
with:
2424
app-id: ${{ vars.SENTRY_RELEASE_BOT_CLIENT_ID }}
2525
private-key: ${{ secrets.SENTRY_RELEASE_BOT_PRIVATE_KEY }}

CHANGELOG.md

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,54 @@
44

55
- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
66

7+
Work in this release was contributed by @sebws. Thank you for your contribution!
8+
9+
## 10.30.0
10+
11+
- feat(nextjs): Deprecate Webpack top-level options ([#18343](https://github.com/getsentry/sentry-javascript/pull/18343))
12+
- feat(node): Capture scope when event loop blocked ([#18040](https://github.com/getsentry/sentry-javascript/pull/18040))
13+
- fix(aws-serverless): Remove hyphens from AWS-lambda origins ([#18353](https://github.com/getsentry/sentry-javascript/pull/18353))
14+
- fix(core): Parse method from Request object in fetch ([#18453](https://github.com/getsentry/sentry-javascript/pull/18453))
15+
- fix(react): Add transaction name guards for rapid lazy-route navigations ([#18346](https://github.com/getsentry/sentry-javascript/pull/18346))
16+
17+
<details>
18+
<summary> <strong>Internal Changes</strong> </summary>
19+
20+
- chore(ci): Fix double issue creation for unreferenced PRs ([#18442](https://github.com/getsentry/sentry-javascript/pull/18442))
21+
- chore(deps): bump next from 15.5.4 to 15.5.7 in /dev-packages/e2e-tests/test-applications/nextjs-15 ([#18411](https://github.com/getsentry/sentry-javascript/pull/18411))
22+
- chore(deps): bump next from 15.5.4 to 15.5.7 in /dev-packages/e2e-tests/test-applications/nextjs-15-intl ([#18400](https://github.com/getsentry/sentry-javascript/pull/18400))
23+
- chore(deps): bump next from 16.0.0 to 16.0.7 in /dev-packages/e2e-tests/test-applications/nextjs-16 ([#18399](https://github.com/getsentry/sentry-javascript/pull/18399))
24+
- chore(deps): bump next from 16.0.0 to 16.0.7 in /dev-packages/e2e-tests/test-applications/nextjs-16-cacheComponents ([#18427](https://github.com/getsentry/sentry-javascript/pull/18427))
25+
- chore(deps): bump next from 16.0.0 to 16.0.7 in /dev-packages/e2e-tests/test-applications/nextjs-16-tunnel ([#18439](https://github.com/getsentry/sentry-javascript/pull/18439))
26+
- chore(publish): Fix publish order for `@sentry/types` ([#18429](https://github.com/getsentry/sentry-javascript/pull/18429))
27+
- ci(deps): bump actions/create-github-app-token from 2.1.4 to 2.2.0 ([#18362](https://github.com/getsentry/sentry-javascript/pull/18362))
28+
29+
</details>
30+
31+
## 10.29.0
32+
33+
### Important Changes
34+
35+
- **feat(solid|solidstart): Bump accepted @solidjs/router range ([#18395](https://github.com/getsentry/sentry-javascript/pull/18395))**
36+
37+
We expanded the supported version range for `@solidjs/router` to include `0.14.x` and `0.15.x` versions.
38+
39+
### Other Changes
40+
41+
- fix(logs): Add support for `msg` in pino integration ([#18389](https://github.com/getsentry/sentry-javascript/pull/18389))
42+
- fix(node): Include system message in anthropic-ai messages span ([#18332](https://github.com/getsentry/sentry-javascript/pull/18332))
43+
- fix(tracing): Add missing attributes in vercel-ai spans ([#18333](https://github.com/getsentry/sentry-javascript/pull/18333))
44+
45+
<details>
46+
<summary> <strong>Internal Changes</strong> </summary>
47+
48+
- chore(tanstackstart-react): clean up re-exported types ([#18393](https://github.com/getsentry/sentry-javascript/pull/18393))
49+
- ref(core): Avoid looking up openai integration options ([#17695](https://github.com/getsentry/sentry-javascript/pull/17695))
50+
- test(nuxt): Relax captured unhandled error assertion ([#18397](https://github.com/getsentry/sentry-javascript/pull/18397))
51+
- test(tanstackstart-react): Set up E2E test application ([#18358](https://github.com/getsentry/sentry-javascript/pull/18358))
52+
53+
</details>
54+
755
## 10.28.0
856

957
### Important Changes

dev-packages/browser-integration-tests/loader-suites/loader/noOnLoad/sdkLoadedInMeanwhile/test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ sentryTest('it does not download the SDK if the SDK was loaded in the meanwhile'
1717
let cdnLoadedCount = 0;
1818
let sentryEventCount = 0;
1919

20-
await page.route('https://dsn.ingest.sentry.io/**/*', route => {
20+
await page.route(/^https:\/\/dsn\.ingest\.sentry\.io\//, route => {
2121
sentryEventCount++;
2222

2323
return route.fulfill({

dev-packages/browser-integration-tests/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@sentry-internal/browser-integration-tests",
3-
"version": "10.28.0",
3+
"version": "10.30.0",
44
"main": "index.js",
55
"license": "MIT",
66
"engines": {
@@ -41,9 +41,9 @@
4141
"dependencies": {
4242
"@babel/core": "^7.27.7",
4343
"@babel/preset-typescript": "^7.16.7",
44-
"@playwright/test": "~1.53.2",
44+
"@playwright/test": "~1.56.0",
4545
"@sentry-internal/rrweb": "2.34.0",
46-
"@sentry/browser": "10.28.0",
46+
"@sentry/browser": "10.30.0",
4747
"@supabase/supabase-js": "2.49.3",
4848
"axios": "^1.12.2",
4949
"babel-loader": "^8.2.2",

dev-packages/browser-integration-tests/suites/integrations/featureFlags/featureFlags/onError/basic/test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ sentryTest('Basic test with eviction, update, and no async tasks', async ({ getL
1212
sentryTest.skip();
1313
}
1414

15-
await page.route('https://dsn.ingest.sentry.io/**/*', route => {
15+
await page.route(/^https:\/\/dsn\.ingest\.sentry\.io\//, route => {
1616
return route.fulfill({
1717
status: 200,
1818
contentType: 'application/json',

0 commit comments

Comments
 (0)