chore(lint): prefer 'unknown' to 'any', fix lint warnings

isaacs · isaacs · commit ab3704ac1f78 · 2025-12-12T09:40:43.000-08:00
Explicitly enable `any` usage in typescript in:

- `dev-packages`, since those are largely integration and E2E tests.
  (This is done with the addition of a `dev-packages/.eslintrc.js`
  file.)
- `packages/*/test/`, since those are all tests. (This is done with a
  rule override added to the root `.eslintrc.js` file.)
- Several one-off allowances, generally for vendored types from third
  party sources, and cases involving method overwriting that TypeScript
  can't follow. (These are done with file/line overrides, explicit `as`
  casting, and adding type inference to the `isInstanceOf` method.)

In other places (ie, in exported production code paths), replace `any`
with `unknown`, and upgrade the `@typescript/no-explicit-any` lint rule
to an error.

This silences a lot of eslint warnings that were habitually ignored, and
encourages us to not opt out of strict type safety in our exported code.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -23,6 +23,9 @@ module.exports = {
     'types/**',
     'scripts/*.js',
   ],
+  rules: {
+    '@typescript-eslint/no-explicit-any': 'error',
+  },
   reportUnusedDisableDirectives: true,
   overrides: [
     {
@@ -36,6 +39,9 @@ module.exports = {
       parserOptions: {
         project: ['tsconfig.test.json'],
       },
+      rules: {
+        '@typescript-eslint/no-explicit-any': 'off',
+      },
     },
     {
       files: ['scripts/**/*.ts'],
diff --git a/dev-packages/.eslintrc.js b/dev-packages/.eslintrc.js
@@ -0,0 +1,7 @@
+module.exports = {
+  extends: ['../.eslintrc.js'],
+  rules: {
+    // tests often have just cause to do evil
+    '@typescript-eslint/no-explicit-any': 'off',
+  },
+};
diff --git a/dev-packages/browser-integration-tests/.eslintrc.js b/dev-packages/browser-integration-tests/.eslintrc.js
@@ -4,7 +4,7 @@ module.exports = {
     node: true,
   },
   // todo: remove regexp plugin from here once we add it to base.js eslint config for the whole project
-  extends: ['../../.eslintrc.js', 'plugin:regexp/recommended'],
+  extends: ['../.eslintrc.js', 'plugin:regexp/recommended'],
   plugins: ['regexp'],
   ignorePatterns: [
     'suites/**/subject.js',
diff --git a/dev-packages/bundler-tests/.eslintrc.js b/dev-packages/bundler-tests/.eslintrc.js
@@ -1,5 +1,5 @@
 module.exports = {
-  extends: ['../../.eslintrc.js'],
+  extends: ['../.eslintrc.js'],
   parserOptions: {
     sourceType: 'module',
   },
diff --git a/dev-packages/clear-cache-gh-action/.eslintrc.cjs b/dev-packages/clear-cache-gh-action/.eslintrc.cjs
@@ -1,6 +1,6 @@
 module.exports = {
   // todo: remove regexp plugin from here once we add it to base.js eslint config for the whole project
-  extends: ['../../.eslintrc.js', 'plugin:regexp/recommended'],
+  extends: ['../.eslintrc.js', 'plugin:regexp/recommended'],
   plugins: ['regexp'],
   parserOptions: {
     sourceType: 'module',
diff --git a/dev-packages/cloudflare-integration-tests/.eslintrc.js b/dev-packages/cloudflare-integration-tests/.eslintrc.js
@@ -3,7 +3,7 @@ module.exports = {
     node: true,
   },
   // todo: remove regexp plugin from here once we add it to base.js eslint config for the whole project
-  extends: ['../../.eslintrc.js', 'plugin:regexp/recommended'],
+  extends: ['../.eslintrc.js', 'plugin:regexp/recommended'],
   plugins: ['regexp'],
   overrides: [
     {
diff --git a/dev-packages/cloudflare-integration-tests/suites/tracing/google-genai/mocks.ts b/dev-packages/cloudflare-integration-tests/suites/tracing/google-genai/mocks.ts
@@ -3,7 +3,6 @@ import type { GoogleGenAIChat, GoogleGenAIClient, GoogleGenAIResponse } from '@s
 export class MockGoogleGenAI implements GoogleGenAIClient {
   public models: {
     generateContent: (...args: unknown[]) => Promise<GoogleGenAIResponse>;
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     generateContentStream: (...args: unknown[]) => Promise<AsyncGenerator<GoogleGenAIResponse, any, unknown>>;
   };
   public chats: {
diff --git a/dev-packages/e2e-tests/.eslintrc.js b/dev-packages/e2e-tests/.eslintrc.js
@@ -3,7 +3,7 @@ module.exports = {
     node: true,
   },
   // todo: remove regexp plugin from here once we add it to base.js eslint config for the whole project
-  extends: ['../../.eslintrc.js', 'plugin:regexp/recommended'],
+  extends: ['../.eslintrc.js', 'plugin:regexp/recommended'],
   plugins: ['regexp'],
   ignorePatterns: ['test-applications/**', 'tmp/**'],
   parserOptions: {
diff --git a/dev-packages/external-contributor-gh-action/.eslintrc.cjs b/dev-packages/external-contributor-gh-action/.eslintrc.cjs
@@ -1,6 +1,6 @@
 module.exports = {
   // todo: remove regexp plugin from here once we add it to base.js eslint config for the whole project
-  extends: ['../../.eslintrc.js', 'plugin:regexp/recommended'],
+  extends: ['../.eslintrc.js', 'plugin:regexp/recommended'],
   plugins: ['regexp'],
   parserOptions: {
     sourceType: 'module',
diff --git a/dev-packages/node-core-integration-tests/.eslintrc.js b/dev-packages/node-core-integration-tests/.eslintrc.js
@@ -3,7 +3,7 @@ module.exports = {
     node: true,
   },
   // todo: remove regexp plugin from here once we add it to base.js eslint config for the whole project
-  extends: ['../../.eslintrc.js', 'plugin:regexp/recommended'],
+  extends: ['../.eslintrc.js', 'plugin:regexp/recommended'],
   plugins: ['regexp'],
   overrides: [
     {
diff --git a/dev-packages/node-integration-tests/.eslintrc.js b/dev-packages/node-integration-tests/.eslintrc.js
@@ -3,7 +3,7 @@ module.exports = {
     node: true,
   },
   // todo: remove regexp plugin from here once we add it to base.js eslint config for the whole project
-  extends: ['../../.eslintrc.js', 'plugin:regexp/recommended'],
+  extends: ['../.eslintrc.js', 'plugin:regexp/recommended'],
   plugins: ['regexp'],
   overrides: [
     {
diff --git a/dev-packages/node-overhead-gh-action/.eslintrc.cjs b/dev-packages/node-overhead-gh-action/.eslintrc.cjs
@@ -3,7 +3,7 @@ module.exports = {
     node: true,
   },
   // todo: remove regexp plugin from here once we add it to base.js eslint config for the whole project
-  extends: ['../../.eslintrc.js', 'plugin:regexp/recommended'],
+  extends: ['../.eslintrc.js', 'plugin:regexp/recommended'],
   plugins: ['regexp'],
   overrides: [
     {
diff --git a/dev-packages/rollup-utils/.eslintrc.cjs b/dev-packages/rollup-utils/.eslintrc.cjs
@@ -1,6 +1,6 @@
 module.exports = {
   // todo: remove regexp plugin from here once we add it to base.js eslint config for the whole project
-  extends: ['../../.eslintrc.js', 'plugin:regexp/recommended'],
+  extends: ['../.eslintrc.js', 'plugin:regexp/recommended'],
   plugins: ['regexp'],
   ignorePatterns: ['otelLoaderTemplate.js.tmpl'],
   sourceType: 'module',
diff --git a/dev-packages/size-limit-gh-action/.eslintrc.cjs b/dev-packages/size-limit-gh-action/.eslintrc.cjs
@@ -1,6 +1,6 @@
 module.exports = {
   // todo: remove regexp plugin from here once we add it to base.js eslint config for the whole project
-  extends: ['../../.eslintrc.js', 'plugin:regexp/recommended'],
+  extends: ['../.eslintrc.js', 'plugin:regexp/recommended'],
   plugins: ['regexp'],
   parserOptions: {
     sourceType: 'module',
diff --git a/dev-packages/test-utils/.eslintrc.js b/dev-packages/test-utils/.eslintrc.js
@@ -3,6 +3,6 @@ module.exports = {
     node: true,
   },
   // todo: remove regexp plugin from here once we add it to base.js eslint config for the whole project
-  extends: ['../../.eslintrc.js', 'plugin:regexp/recommended'],
+  extends: ['../.eslintrc.js', 'plugin:regexp/recommended'],
   plugins: ['regexp'],
 };
diff --git a/packages/aws-serverless/src/integration/instrumentation-aws-lambda/types.ts b/packages/aws-serverless/src/integration/instrumentation-aws-lambda/types.ts
@@ -15,6 +15,7 @@
  * limitations under the License.
  */
 
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import type { Context as OtelContext, Span } from '@opentelemetry/api';
 import type { InstrumentationConfig } from '@opentelemetry/instrumentation';
 import type { Context } from 'aws-lambda';
diff --git a/packages/cloudflare/src/durableobject.ts b/packages/cloudflare/src/durableobject.ts
@@ -28,7 +28,8 @@ type MethodWrapperOptions = {
 };
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
-type OriginalMethod = (...args: any[]) => any;
+type UncheckedMethod = (...args: any[]) => any;
+type OriginalMethod = UncheckedMethod;
 
 function wrapMethodWithSentry<T extends OriginalMethod>(
   wrapperOptions: MethodWrapperOptions,
@@ -269,8 +270,7 @@ export function instrumentDurableObjectWithSentry<
           // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-explicit-any
           (obj as any)[method] = wrapMethodWithSentry(
             { options, context, spanName: method, spanOp: 'rpc' },
-            // eslint-disable-next-line @typescript-eslint/no-explicit-any
-            value as (...args: any[]) => any,
+            value as UncheckedMethod,
           );
         }
       }
@@ -332,7 +332,7 @@ function instrumentPrototype<T extends NewableFunction>(target: T, methodsToInst
     }
 
     // Create a wrapper that gets context/options from the instance at runtime
-    const wrappedMethod = function (this: any, ...args: any[]): unknown {
+    const wrappedMethod = function (this: unknown, ...args: unknown[]): unknown {
       const thisWithSentry = this as {
         __SENTRY_CONTEXT__: DurableObjectState;
         __SENTRY_OPTIONS__: CloudflareOptions;
@@ -342,7 +342,7 @@ function instrumentPrototype<T extends NewableFunction>(target: T, methodsToInst
 
       if (!instanceOptions) {
         // Fallback to original method if no Sentry data found
-        return (originalMethod as (...args: any[]) => any).apply(this, args);
+        return (originalMethod as UncheckedMethod).apply(this, args);
       }
 
       // Use the existing wrapper but with instance-specific context/options
@@ -353,12 +353,12 @@ function instrumentPrototype<T extends NewableFunction>(target: T, methodsToInst
           spanName: methodName,
           spanOp: 'rpc',
         },
-        originalMethod as (...args: any[]) => any,
+        originalMethod as UncheckedMethod,
         undefined,
         true, // noMark = true since we'll mark the prototype method
       );
 
-      return (wrapper as (...args: any[]) => any).apply(this, args);
+      return wrapper.apply(this, args);
     };
 
     markAsInstrumented(wrappedMethod);
diff --git a/packages/core/src/integrations/supabase.ts b/packages/core/src/integrations/supabase.ts
@@ -1,6 +1,7 @@
 // Based on Kamil Ogórek's work on:
 // https://github.com/supabase-community/sentry-integration-js
 
+/* eslint-disable @typescript-eslint/no-explicit-any */
 /* eslint-disable max-lines */
 import { addBreadcrumb } from '../breadcrumbs';
 import { DEBUG_BUILD } from '../debug-build';
diff --git a/packages/core/src/types-hoist/breadcrumb.ts b/packages/core/src/types-hoist/breadcrumb.ts
@@ -52,6 +52,7 @@ export interface Breadcrumb {
    *
    * @summary Arbitrary data associated with this breadcrumb.
    */
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   data?: { [key: string]: any };
 
   /**
@@ -70,6 +71,7 @@ export interface Breadcrumb {
 
 /** JSDoc */
 export interface BreadcrumbHint {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   [key: string]: any;
 }
 
@@ -90,6 +92,7 @@ export interface XhrBreadcrumbData {
 }
 
 export interface FetchBreadcrumbHint {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   input: any[];
   data?: unknown;
   response?: unknown;
diff --git a/packages/core/src/types-hoist/context.ts b/packages/core/src/types-hoist/context.ts
@@ -99,6 +99,7 @@ export interface ResponseContext extends Record<string, unknown> {
 }
 
 export interface TraceContext extends Record<string, unknown> {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   data?: { [key: string]: any };
   op?: string;
   parent_span_id?: string;
diff --git a/packages/core/src/types-hoist/error.ts b/packages/core/src/types-hoist/error.ts
@@ -2,5 +2,5 @@
  * Just an Error object with arbitrary attributes attached to it.
  */
 export interface ExtendedError extends Error {
-  [key: string]: any;
+  [key: string]: unknown;
 }
diff --git a/packages/core/src/types-hoist/event.ts b/packages/core/src/types-hoist/event.ts
@@ -83,6 +83,7 @@ export interface EventHint {
   syntheticException?: Error | null;
   originalException?: unknown;
   attachments?: Attachment[];
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   data?: any;
   integrations?: string[];
 }
diff --git a/packages/core/src/types-hoist/instrument.ts b/packages/core/src/types-hoist/instrument.ts
@@ -47,6 +47,7 @@ interface SentryFetchData {
 }
 
 export interface HandlerDataFetch {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   args: any[];
   fetchData: SentryFetchData; // This data is among other things dumped directly onto the fetch breadcrumb data
   startTimestamp: number;
@@ -74,6 +75,7 @@ export interface HandlerDataDom {
 
 export interface HandlerDataConsole {
   level: ConsoleLevel;
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   args: any[];
 }
 
diff --git a/packages/core/src/types-hoist/integration.ts b/packages/core/src/types-hoist/integration.ts
@@ -47,4 +47,5 @@ export interface Integration {
  * An integration in function form.
  * This is expected to return an integration.
  */
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 export type IntegrationFn<IntegrationType = Integration> = (...rest: any[]) => IntegrationType;
diff --git a/packages/core/src/types-hoist/misc.ts b/packages/core/src/types-hoist/misc.ts
@@ -4,7 +4,7 @@ import type { QueryParams } from './request';
  * Data extracted from an incoming request to a node server
  */
 export interface ExtractedNodeRequestData {
-  [key: string]: any;
+  [key: string]: unknown;
 
   /** Specific headers from the request */
   headers?: { [key: string]: string };
diff --git a/packages/core/src/types-hoist/polymorphics.ts b/packages/core/src/types-hoist/polymorphics.ts
@@ -50,12 +50,14 @@ type NextjsRequest = NodeRequest & {
     [key: string]: string;
   };
   query?: {
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     [key: string]: any;
   };
 };
 
 type ExpressRequest = NodeRequest & {
   baseUrl?: string;
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   body?: string | { [key: string]: any };
   host?: string;
   hostname?: string;
@@ -70,9 +72,11 @@ type ExpressRequest = NodeRequest & {
     ];
   };
   query?: {
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     [key: string]: any;
   };
   user?: {
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     [key: string]: any;
   };
   _reconstructedRoute?: string;
diff --git a/packages/core/src/types-hoist/samplingcontext.ts b/packages/core/src/types-hoist/samplingcontext.ts
@@ -6,7 +6,7 @@ import type { SpanAttributes } from './span';
  * Context data passed by the user when starting a transaction, to be used by the tracesSampler method.
  */
 export interface CustomSamplingContext {
-  [key: string]: any;
+  [key: string]: unknown;
 }
 
 /**
diff --git a/packages/core/src/types-hoist/stackframe.ts b/packages/core/src/types-hoist/stackframe.ts
@@ -13,7 +13,7 @@ export interface StackFrame {
   in_app?: boolean;
   instruction_addr?: string;
   addr_mode?: string;
-  vars?: { [key: string]: any };
+  vars?: { [key: string]: unknown };
   debug_id?: string;
-  module_metadata?: any;
+  module_metadata?: unknown;
 }
diff --git a/packages/core/src/types-hoist/user.ts b/packages/core/src/types-hoist/user.ts
@@ -2,7 +2,7 @@
  * An interface describing a user of an application or a handled request.
  */
 export interface User {
-  [key: string]: any;
+  [key: string]: unknown;
   id?: string | number;
   ip_address?: string | null;
   email?: string;
diff --git a/packages/core/src/utils/aggregate-errors.ts b/packages/core/src/utils/aggregate-errors.ts
@@ -64,7 +64,7 @@ function aggregateExceptionsFromError(
       exceptionFromErrorImplementation,
       parser,
       limit,
-      error[key],
+      error[key] as ExtendedError,
       key,
       [newException, ...newExceptions],
       newException,
@@ -85,7 +85,7 @@ function aggregateExceptionsFromError(
           exceptionFromErrorImplementation,
           parser,
           limit,
-          childError,
+          childError as ExtendedError,
           key,
           [newException, ...newExceptions],
           newException,
diff --git a/packages/core/src/utils/is.ts b/packages/core/src/utils/is.ts
@@ -180,7 +180,7 @@ export function isSyntheticEvent(wat: unknown): boolean {
  * @param base A constructor to be used in a check.
  * @returns A boolean representing the result.
  */
-export function isInstanceOf(wat: any, base: any): boolean {
+export function isInstanceOf<T>(wat: unknown, base: { new (...args: any[]): T }): wat is T {
   try {
     return wat instanceof base;
   } catch {
diff --git a/packages/core/test/lib/utils/is.test.ts b/packages/core/test/lib/utils/is.test.ts
@@ -107,15 +107,24 @@ describe('isInstanceOf()', () => {
     expect(isInstanceOf(new Date(), Date)).toEqual(true);
     // @ts-expect-error Foo implicity has any type, doesn't have constructor
     expect(isInstanceOf(new Foo(), Foo)).toEqual(true);
-
+    // @ts-expect-error Should only allow constructors
     expect(isInstanceOf(new Error('wat'), Foo)).toEqual(false);
     expect(isInstanceOf(new Date('wat'), Error)).toEqual(false);
+
+    // verify type inference
+    const d: unknown = new Date();
+    const e: Date = isInstanceOf(d, Date) ? d : new Date();
+    expect(e).toEqual(d);
   });
 
   test('should not break with incorrect input', () => {
+    // @ts-expect-error Should only allow constructors
     expect(isInstanceOf(new Error('wat'), 1)).toEqual(false);
+    // @ts-expect-error Should only allow constructors
     expect(isInstanceOf(new Error('wat'), 'wat')).toEqual(false);
+    // @ts-expect-error Should only allow constructors
     expect(isInstanceOf(new Error('wat'), null)).toEqual(false);
+    // @ts-expect-error Should only allow constructors
     expect(isInstanceOf(new Error('wat'), undefined)).toEqual(false);
   });
 });
diff --git a/packages/feedback/src/modal/integration.tsx b/packages/feedback/src/modal/integration.tsx
diff --git a/packages/nextjs/src/config/types.ts b/packages/nextjs/src/config/types.ts
diff --git a/packages/node/src/integrations/tracing/fastify/types.ts b/packages/node/src/integrations/tracing/fastify/types.ts
diff --git a/packages/node/src/integrations/tracing/fastify/v3/instrumentation.ts b/packages/node/src/integrations/tracing/fastify/v3/instrumentation.ts
diff --git a/packages/node/src/integrations/tracing/fastify/v3/types.ts b/packages/node/src/integrations/tracing/fastify/v3/types.ts
diff --git a/packages/node/src/integrations/tracing/fastify/v3/utils.ts b/packages/node/src/integrations/tracing/fastify/v3/utils.ts
diff --git a/packages/node/src/integrations/tracing/firebase/otel/patches/firestore.ts b/packages/node/src/integrations/tracing/firebase/otel/patches/firestore.ts
diff --git a/packages/node/src/integrations/tracing/firebase/otel/types.ts b/packages/node/src/integrations/tracing/firebase/otel/types.ts
diff --git a/packages/node/src/integrations/tracing/postgresjs.ts b/packages/node/src/integrations/tracing/postgresjs.ts
diff --git a/packages/remix/src/utils/types.ts b/packages/remix/src/utils/types.ts
diff --git a/packages/remix/src/vendor/instrumentation.ts b/packages/remix/src/vendor/instrumentation.ts
diff --git a/packages/replay-internal/rollup.npm.config.mjs b/packages/replay-internal/rollup.npm.config.mjs
diff --git a/packages/replay-internal/src/types/rrweb.ts b/packages/replay-internal/src/types/rrweb.ts
diff --git a/packages/vercel-edge/src/vendored/async-local-storage-context-manager.ts b/packages/vercel-edge/src/vendored/async-local-storage-context-manager.ts
diff --git a/packages/vercel-edge/test/wintercg-fetch.test.ts b/packages/vercel-edge/test/wintercg-fetch.test.ts
diff --git a/packages/vue/src/pinia.ts b/packages/vue/src/pinia.ts

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ module.exports = {`
`3`	`3`	`node: true,`
`4`	`4`	`},`
`5`	`5`	`// todo: remove regexp plugin from here once we add it to base.js eslint config for the whole project`
`6`		`- extends: ['../../.eslintrc.js', 'plugin:regexp/recommended'],`
	`6`	`+ extends: ['../.eslintrc.js', 'plugin:regexp/recommended'],`
`7`	`7`	`plugins: ['regexp'],`
`8`	`8`	`overrides: [`
`9`	`9`	`{`