Skip to content

🛠 Repo: Bump markdownlint-cli from 0.30 to 0.45 #5486

@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Tooling Suggestion Checklist

Overview

Mocha has a devDependency right now on a 4-year-old version of markdownlint-cli:

"markdownlint-cli": "^0.30.0",

This isn't a problem on its own. [email protected] works as-is. But it pulls in old dependencies that bloat our local node_modules size. For example, in #5484, we see it pulling in strip-json-comments@3:

$ npm ls strip-json-comments@3
[email protected] /Users/josh/repos/mocha
├─┬ [email protected]
│ └─┬ @eslint/[email protected]
│   └── [email protected]
├─┬ [email protected]
│ └── [email protected]
└─┬ [email protected]
  └─┬ [email protected]
    └── [email protected]

I think it'd be a good idea in general to bump it to the latest major version.

Additional Info

In theory it'd be nice to automatically upgrade all devDependencies. #5055 is blocked for now: #5055 (comment).

We'll have to do some work to identify potential breaking changes, there is no changelog file in the repo, just a list of releases in GitHub: https://github.com/igorshubovych/markdownlint-cli/releases

💖

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions