chore: apply precommit changes

Author: nammn

.pre-commit-config.yaml

@@ -95,81 +95,33 @@ repos:
             ^scripts/funcs/[^/]+$
           )
 
+  # Formatting hooks (these modify files)
+  - repo: https://github.com/psf/black
+    rev: 24.10.0
+    hooks:
+      - id: black
+        language_version: python3
+
+  - repo: https://github.com/pycqa/isort
+    rev: 5.13.2
+    hooks:
+      - id: isort
+        args: ["--profile", "black"]
+
+  # Slow linting/generation hooks last
   - repo: https://github.com/golangci/golangci-lint
     rev: v1.62.2
     hooks:
       - id: golangci-lint
         args: [--timeout=10m]
 
   # Local hooks for project-specific tasks
+  # These run in parallel via scripts/dev/generate_files.sh
   - repo: local
     hooks:
-      - id: update-release-json
-        name: update-release-json
-        entry: scripts/dev/generate_files.sh update_release
-        language: system
-        pass_filenames: false
-        stages: [pre-commit]
-
-      - id: update-values-yaml
-        name: update-values-yaml
-        entry: scripts/dev/generate_files.sh update_values
-        language: system
-        pass_filenames: false
-        stages: [pre-commit]
-
-      - id: generate-standalone-yaml
-        name: generate-standalone-yaml
-        entry: scripts/dev/generate_files.sh generate_standalone_yaml
-        language: system
-        pass_filenames: false
-        stages: [pre-commit]
-
-      - id: generate-manifests
-        name: generate-manifests
-        entry: scripts/dev/generate_files.sh generate_manifests
-        language: system
-        pass_filenames: false
-        stages: [pre-commit]
-
-      - id: regenerate-mco-tests
-        name: regenerate-mco-tests
-        entry: scripts/dev/generate_files.sh update_mco_tests
-        language: system
-        pass_filenames: false
-        stages: [pre-commit]
-
-      - id: regenerate-multicluster-rbac
-        name: regenerate-multicluster-rbac
-        entry: scripts/dev/regenerate_multicluster_rbac.sh
-        language: system
-        pass_filenames: false
-        stages: [pre-commit]
-
-      - id: update-licenses
-        name: update-licenses
-        entry: scripts/dev/generate_files.sh update_licenses
-        language: system
-        pass_filenames: false
-        stages: [pre-commit]
-
-      - id: validate-snippets
-        name: validate-snippets
-        entry: scripts/code_snippets/validate_snippets.py
-        language: system
-        pass_filenames: false
-        stages: [pre-commit]
-
-      - id: check-kubebuilder-annotations
-        name: check-kubebuilder-annotations
-        entry: bash -c 'if grep -r "// kubebuilder" --include="*.go" --exclude-dir=vendor .; then echo "Found erroneous kubebuilder annotation"; exit 1; fi'
-        language: system
-        pass_filenames: false
-        stages: [pre-commit]
-
-      - id: helm-lint
-        name: helm-lint
-        entry: scripts/dev/lint_helm_chart.sh
+      - id: generate-and-validate
+        name: generate-and-validate (parallel)
+        entry: scripts/dev/generate_files.sh generate_all
         language: system
         pass_filenames: false
         stages: [pre-commit]

changelog/20251210_other_remove_unused_mdb_image_type_env_variable.md

@@ -0,0 +1,6 @@
+---
+kind: other
+date: 2025-12-10
+---
+
+* **Operator configuration**: Removed the unused `MDB_IMAGE_TYPE` environment variable and the corresponding `mongodb.imageType` Helm value. This variable was deprecated in v1.28.0 of the MongoDB Enterprise Kubernetes Operator when it switched to architecture-based image selection (ubi9 for static, ubi8 for non-static). This is a cleanup change with no functional impact.

config/manager/manager.yaml

@@ -94,8 +94,6 @@ spec:
               value: mongodb-enterprise-server
             - name: MONGODB_REPO_URL
               value: quay.io/mongodb
-            - name: MDB_IMAGE_TYPE
-              value: ubi8
             - name: PERFORM_FAILOVER
               value: 'true'
             - name: MDB_WEBHOOK_REGISTER_CONFIGURATION

docker/cluster-cleaner/scripts/clean-failed-namespaces.sh

@@ -7,12 +7,12 @@ delete_resources_safely() {
     resource_type="$1"
     namespace="$2"
 
-    echo "Attempting normal deletion of $resource_type in $namespace..."
+    echo "Attempting normal deletion of ${resource_type} in ${namespace}..."
     kubectl delete "${resource_type}" --all -n "${namespace}" --wait=true --timeout=10s 2>error.log|| true
 
     # Check if any resources are still stuck
     # Let's not fail here and continue deletion
-    resources=$(kubectl get "$resource_type" -n "${namespace}" --no-headers -o custom-columns=":metadata.name" 2>error.log || true)
+    resources=$(kubectl get "${resource_type}" -n "${namespace}" --no-headers -o custom-columns=":metadata.name" 2>error.log || true)
 
     for resource in ${resources}; do
         echo "${resource_type}/${resource} is still present, force deleting..."
@@ -39,7 +39,7 @@ kubectl get namespace -l "${LABELS}" -o name
 for namespace in $(kubectl get namespace -l "${LABELS}" -o name 2>error.log); do
     creation_time=$(kubectl get "${namespace}" -o jsonpath='{.metadata.creationTimestamp}' 2>error.log || echo "")
 
-    if [ -z "$creation_time" ]; then
+    if [ -z "${creation_time}" ]; then
         echo "Namespace ${namespace} does not exist or has no creation timestamp, skipping."
         continue
     fi

docker/delve-sidecar/attach-delve.sh

@@ -8,6 +8,6 @@ while ! pgrep -f "mongodb-mms-automation-agent" > /dev/null; do
 done
 
 APP_PID=$(pgrep -f "mongodb-mms-automation-agent")
-echo "Found app with PID: $APP_PID, attaching Delve..."
+echo "Found app with PID: ${APP_PID}, attaching Delve..."
 
-dlv attach "$APP_PID" --headless --listen=:2345 --api-version=2 --accept-multiclient --continue
+dlv attach "${APP_PID}" --headless --listen=:2345 --api-version=2 --accept-multiclient --continue

docker/mongodb-agent/agent-launcher-shim.sh

@@ -9,13 +9,13 @@ SCRIPTS_DIR="/opt/scripts"
 # Function to start the agent launcher
 start_agent_launcher() {
   echo "Starting agent launcher..."
-  echo "Final contents of $SCRIPTS_DIR:"
-  ls -la "$SCRIPTS_DIR"
+  echo "Final contents of ${SCRIPTS_DIR}:"
+  ls -la "${SCRIPTS_DIR}"
 
-  if [[ -f "$SCRIPTS_DIR/agent-launcher.sh" ]]; then
+  if [[ -f "${SCRIPTS_DIR}/agent-launcher.sh" ]]; then
     echo "Found agent-launcher.sh, executing..."
     echo "Note: agent-launcher.sh will become PID 1 and handle all signal processing including cleanup"
-    exec "$SCRIPTS_DIR/agent-launcher.sh"
+    exec "${SCRIPTS_DIR}/agent-launcher.sh"
   else
     echo "ERROR: agent-launcher.sh not found"
     exit 1

docker/mongodb-agent/dummy-probe.sh

@@ -4,34 +4,34 @@
 find_init_container() {
   local pid
   pid=$(pgrep -f "agent-utilities-holder_marker" | head -n1)
-  if [[ -n "$pid" && -d "/proc/$pid/root/probes" ]]; then
-    echo "$pid"
+  if [[ -n "${pid}" && -d "/proc/${pid}/root/probes" ]]; then
+    echo "${pid}"
     return 0
   fi
   return 1
 }
 
 execute_liveness_probe() {
   local init_pid="$1"
-  local init_probe_path="/proc/$init_pid/root/probes/probe.sh"
+  local init_probe_path="/proc/${init_pid}/root/probes/probe.sh"
 
-  if [[ ! -f "$init_probe_path" ]]; then
-    echo "ERROR: Liveness probe script not found at $init_probe_path"
+  if [[ ! -f "${init_probe_path}" ]]; then
+    echo "ERROR: Liveness probe script not found at ${init_probe_path}"
     exit 1
-  elif [[ ! -x "$init_probe_path" ]]; then
-    echo "ERROR: Liveness probe script not executable at $init_probe_path"
+  elif [[ ! -x "${init_probe_path}" ]]; then
+    echo "ERROR: Liveness probe script not executable at ${init_probe_path}"
     exit 1
   else
     # Execute the actual probe script from the init-database container
     # This works because of shared process namespace - the probe can see all processes
-    exec "$init_probe_path"
+    exec "${init_probe_path}"
   fi
 }
 
 # Main execution
 if init_pid=$(find_init_container); then
-  echo "Found init container with PID: $init_pid, executing liveness probe..."
-  execute_liveness_probe "$init_pid"
+  echo "Found init container with PID: ${init_pid}, executing liveness probe..."
+  execute_liveness_probe "${init_pid}"
 else
   echo "WARNING: Init container not found, falling back to basic liveness check"
   # Fallback: if we can't find the init container, just check if this container is alive

docker/mongodb-agent/setup-agent-files.sh

@@ -8,8 +8,8 @@ SCRIPTS_DIR="/opt/scripts"
 # readiness always returns failure
 setup_dummy_probes() {
   echo "Setting up dummy probe scripts..."
-  cp --remove-destination /usr/local/bin/dummy-probe.sh "$SCRIPTS_DIR/probe.sh"
-  cp --remove-destination /usr/local/bin/dummy-readinessprobe "$SCRIPTS_DIR/readinessprobe"
+  cp --remove-destination /usr/local/bin/dummy-probe.sh "${SCRIPTS_DIR}/probe.sh"
+  cp --remove-destination /usr/local/bin/dummy-readinessprobe "${SCRIPTS_DIR}/readinessprobe"
   echo "Dummy probe scripts ready"
 }
 
@@ -18,11 +18,11 @@ find_init_container() {
   for i in {1..150}; do
     local pid
     pid=$(pgrep -f "agent-utilities-holder_marker" | head -n1)
-    if [[ -n "$pid" && -d "/proc/$pid/root/scripts" ]]; then
-      echo "$pid"
+    if [[ -n "${pid}" && -d "/proc/${pid}/root/scripts" ]]; then
+      echo "${pid}"
       return 0
     fi
-    echo "Waiting for init container... (attempt $i)" >&2
+    echo "Waiting for init container... (attempt ${i})" >&2
     sleep 2
   done
   return 1
@@ -33,8 +33,8 @@ link_agent_scripts() {
 
   echo "Linking agent launcher scripts..."
   for script in agent-launcher.sh agent-launcher-lib.sh; do
-    ln -sf "$init_scripts_dir/$script" "$SCRIPTS_DIR/$script"
-    echo "Linked $script"
+    ln -sf "${init_scripts_dir}/${script}" "${SCRIPTS_DIR}/${script}"
+    echo "Linked ${script}"
   done
 }
 
@@ -44,26 +44,26 @@ main() {
   setup_dummy_probes
 
   if init_pid=$(find_init_container); then
-    echo "Found init container with PID: $init_pid"
+    echo "Found init container with PID: ${init_pid}"
 
-    init_root="/proc/$init_pid/root"
-    init_scripts="$init_root/scripts"
-    init_probes="$init_root/probes"
+    init_root="/proc/${init_pid}/root"
+    init_scripts="${init_root}/scripts"
+    init_probes="${init_root}/probes"
 
     # Verify scripts directory exists
-    if [[ ! -d "$init_scripts" ]]; then
-      echo "ERROR: Scripts directory $init_scripts not found"
+    if [[ ! -d "${init_scripts}" ]]; then
+      echo "ERROR: Scripts directory ${init_scripts} not found"
       exit 1
     fi
 
     # Verify probes directory exists
-    if [[ ! -d "$init_probes" ]]; then
-      echo "ERROR: Probes directory $init_probes not found"
+    if [[ ! -d "${init_probes}" ]]; then
+      echo "ERROR: Probes directory ${init_probes} not found"
       exit 1
     fi
 
     # Link scripts from init container
-    link_agent_scripts "$init_scripts"
+    link_agent_scripts "${init_scripts}"
 
     echo "File setup completed successfully"
     exit 0

docker/mongodb-kubernetes-init-database/content/probe.sh

@@ -4,7 +4,7 @@ set -Eeou pipefail
 check_process() {
   local check_process=$1
   # shellcheck disable=SC2009
-  ps -ax | grep -v " grep " | grep -v jq | grep -v tail | grep "$check_process"
+  ps -ax | grep -v " grep " | grep -v jq | grep -v tail | grep "${check_process}"
   return $?
 }
 

docker/mongodb-kubernetes-tests/kubetester/__init__.py

@@ -11,10 +11,7 @@
 
 # Re-exports
 from .kubetester import fixture as find_fixture
-from .security_context import (
-    assert_pod_container_security_context,
-    assert_pod_security_context,
-)
+from .security_context import assert_pod_container_security_context, assert_pod_security_context
 
 
 def create_secret(