[FIX] estate: Server101 Fixing bugs based on cleanup

Author: VincentJanssen-Code

estate/__manifest__.py

@@ -13,6 +13,8 @@
         'views/estate_property_tag_views.xml',
         'views/estate_property_offer_views.xml',
         'views/estate_menu_views.xml',
-        'security/ir.model.access.csv']
+        'security/ir.model.access.csv'],
+    'author': 'Odoo S.A.',
+    'license': 'LGPL-3'
 
 }

estate/models/estate_property.py

@@ -25,7 +25,7 @@ class EstateProperty(models.Model):
     description = fields.Text()
     postcode = fields.Char()
     date_availability = fields.Date("Available From", copy=False, default=lambda self: fields.Datetime.today() + relativedelta(months=3))
-    last_seen = fields.Date("Last Seen", default=lambda self: fields.Datetime.now)
+    last_seen = fields.Date("Last Seen", default=lambda self: fields.Datetime.now())
     expected_price = fields.Float(required=True)
     selling_price = fields.Float(readonly=True, copy=False)
     best_price = fields.Float(string="Best Price", compute="_compute_best_price")
@@ -70,7 +70,6 @@ def _compute_total_area(self):
     @api.depends('offer_ids')
     def _compute_best_price(self):
         for record in self:
-            max: int = 0
             if (not record.offer_ids):
                 record.best_price = 0
                 continue

estate/views/estate_property_views.xml

@@ -29,7 +29,7 @@
                 <header>
                     <button name="sell_property" type="object" string="Sell"/>
                     <button name="cancel_property" type="object" string="Cancel"/>
-                    <field name="state" widget="statusbar" statusbar_visible="New,Offer_Received,Offer_Accepted,Sold,Cancelled"/>
+                    <field name="state" widget="statusbar" statusbar_visible="new,offer_received,offer_accepted,sold,cancelled"/>
                 </header>
                 <sheet>
                     <group>