Skip to content

Commit 2dc2d3f

Browse files
committed
ci: remove attempt to run e2e on windows, that needs way more effort
1 parent 358727b commit 2dc2d3f

File tree

1 file changed

+7
-19
lines changed

1 file changed

+7
-19
lines changed

.github/workflows/run-tests.yml

Lines changed: 7 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -68,21 +68,13 @@ jobs:
6868
6969
e2e:
7070
needs: setup
71+
runs-on: ubuntu-latest
7172
strategy:
7273
fail-fast: false
7374
matrix:
74-
os: ${{ fromJson(needs.setup.outputs.os) }}
7575
version: ${{ fromJson(needs.setup.outputs.matrix) }}
7676
shard: [1, 2, 3, 4, 5]
77-
exclude:
78-
- os: windows-2025
79-
version: "13.5.1"
80-
- os: windows-2025
81-
version: "14.2.35"
82-
- os: windows-2025
83-
version: "15.5.9"
8477

85-
runs-on: ${{ matrix.os }}
8678
steps:
8779
- uses: actions/checkout@v6
8880
- name: Resolve Next.js version
@@ -112,6 +104,7 @@ jobs:
112104
- uses: oven-sh/setup-bun@v2
113105
- name: setup pnpm/yarn
114106
run: |
107+
npm install -g corepack
115108
corepack enable
116109
shell: bash
117110
- name: Install Deno
@@ -126,7 +119,7 @@ jobs:
126119
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
127120
run: |
128121
# Control netlify-cli as a regular dev dep but expose it globally for test fixtures to use
129-
npm install -g "netlify-cli@$(npm list --json --depth=0 netlify-cli | jq -r '.dependencies["netlify-cli"].version')"
122+
npm install -g "netlify-cli@$(npm list --json --depth=0 netlify-cli | jq -r ".dependencies[\"netlify-cli\"].version")"
130123
npx netlify login
131124
- name: Get installed Playwright version
132125
id: playwright-version
@@ -152,7 +145,7 @@ jobs:
152145
uses: actions/upload-artifact@v5
153146
if: always()
154147
with:
155-
name: blob-report-${{matrix.version}}-${{ matrix.shard }}-${{ matrix.os }}
148+
name: blob-report-${{matrix.version}}-${{ matrix.shard }}
156149
path: blob-report
157150
retention-days: 1
158151

@@ -249,14 +242,11 @@ jobs:
249242
smoke:
250243
if: always()
251244
needs: setup
252-
245+
runs-on: ubuntu-latest
253246
strategy:
254247
fail-fast: false
255248
matrix:
256-
os: ${{ fromJson(needs.setup.outputs.os) }}
257249
version: ${{ fromJson(needs.setup.outputs.matrix) }}
258-
259-
runs-on: ${{ matrix.os }}
260250
steps:
261251
- uses: actions/checkout@v6
262252
- name: Resolve Next.js version
@@ -300,7 +290,7 @@ jobs:
300290
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
301291
run: |
302292
# Control netlify-cli as a regular dev dep but expose it globally for test fixtures to use
303-
npm install -g "netlify-cli@$(npm list --json --depth=0 netlify-cli | jq -r '.dependencies["netlify-cli"].version')"
293+
npm install -g "netlify-cli@$(npm list --json --depth=0 netlify-cli | jq -r ".dependencies[\"netlify-cli\"].version")"
304294
npx netlify login
305295
- name: "Smoke tests"
306296
run: npm run test:ci:smoke
@@ -316,8 +306,6 @@ jobs:
316306
strategy:
317307
fail-fast: false
318308
matrix:
319-
# we do have per OS runs, but we don't need to run on windows to merge reports
320-
os: ${{ fromJson(needs.setup.outputs.os) }}
321309
version: ${{ fromJson(needs.setup.outputs.matrix) }}
322310

323311
runs-on: ubuntu-latest
@@ -344,6 +332,6 @@ jobs:
344332
- name: Upload HTML report
345333
uses: actions/upload-artifact@v5
346334
with:
347-
name: html-report-${{ matrix.version }}-attempt-${{ github.run_attempt }}-${{ matrix.os }}
335+
name: html-report-${{ matrix.version }}-attempt-${{ github.run_attempt }}
348336
path: playwright-report
349337
retention-days: 14

0 commit comments

Comments
 (0)