Skip to content

Commit 75bf02d

Browse files
committed
ignore test with defaults on macos
1 parent 0bc5196 commit 75bf02d

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

tests/ui/eii/default/call_default.rs

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,17 @@
33
//@ run-pass
44
//@ check-run-results
55
//@ ignore-backends: gcc
6+
// functions can have target-cpu applied.
7+
// On apple-darwin this is super important,
8+
// since you can have binaries which mix x86 and aarch64 code that are compatible
9+
// with both architectures. So we can't just reject target_cpu on EIIs since apple
10+
// puts them on by default. The problem: we generate aliases. And aliases cannot
11+
// get target_cpu applied to them. So, instead we should, in the case of functions,
12+
// generate a shim function. For statics aliases should keep working in theory.
13+
// In fact, aliases are only necessary for statics. For functions we could just
14+
// always generate a shim and a previous version of EII did so but I was sad
15+
// that that'd never support statics.
16+
//@ ignore-macos
617
// Tests EIIs with default implementations.
718
// When there's no explicit declaration, the default should be called from the declaring crate.
819
#![feature(extern_item_impls)]

tests/ui/eii/same-symbol.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
//@ run-pass
22
//@ check-run-results
3+
//@ ignore-backends: gcc
34
#![feature(extern_item_impls)]
45

56
pub mod a {

0 commit comments

Comments
 (0)