fix: minor changes for deps

Author: mochiya98

README.md

@@ -95,10 +95,7 @@ const crypto = require('crypto');
 const BUILD_CACHE_TIMEOUT = 24 * 3600; // 1 day
 
 function digest(str) {
-  return crypto
-    .createHash('md5')
-    .update(str)
-    .digest('hex');
+  return crypto.createHash('md5').update(str).digest('hex');
 }
 
 // Generate own cache key

src/index.js

@@ -1,6 +1,4 @@
-/* eslint-disable
-  import/order
-*/
+/* eslint-disable import/order */
 const fs = require('fs');
 const os = require('os');
 const v8 = require('v8');
@@ -169,7 +167,7 @@ function pitch(remainingRequest, prevRequest, dataInput) {
 
   const callback = this.async();
   const data = dataInput;
-  const { emitFile } = this;
+  const emitFile = this.emitFile.bind(this);
 
   data.remainingRequest = remainingRequest;
   data.cacheKey = cacheKeyFn(options, data.remainingRequest);
@@ -270,10 +268,7 @@ function pitch(remainingRequest, prevRequest, dataInput) {
 }
 
 function digest(str) {
-  return crypto
-    .createHash('md5')
-    .update(str)
-    .digest('hex');
+  return crypto.createHash('md5').update(str).digest('hex');
 }
 
 const directories = new Set();
@@ -286,16 +281,15 @@ function write(key, data, callback) {
     // for performance skip creating directory
     fs.writeFile(key, content, callback);
   } else {
-    mkdirp(dirname, (mkdirErr) => {
-      if (mkdirErr) {
+    mkdirp(dirname).then(
+      () => {
+        directories.add(dirname);
+        fs.writeFile(key, content, callback);
+      },
+      (mkdirErr) => {
         callback(mkdirErr);
-        return;
       }
-
-      directories.add(dirname);
-
-      fs.writeFile(key, content, callback);
-    });
+    );
   }
 }
 

test/__snapshots__/validate-options.test.js.snap

@@ -1,25 +1,25 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`validate options error (pitch) 1`] = `
-"Invalid options object. Cache Loader (Pitch) has been initialised using an options object that does not match the API schema.
+"Invalid options object. Cache Loader (Pitch) has been initialized using an options object that does not match the API schema.
  - options.cacheIdentifier should be a string.
    -> Provide an invalidation identifier which is used to generate the hashes. You can use it for extra dependencies of loaders (used for default read/write implementation)."
 `;
 
 exports[`validate options error 1`] = `
-"Invalid options object. Cache Loader has been initialised using an options object that does not match the API schema.
+"Invalid options object. Cache Loader has been initialized using an options object that does not match the API schema.
  - options.cacheIdentifier should be a string.
    -> Provide an invalidation identifier which is used to generate the hashes. You can use it for extra dependencies of loaders (used for default read/write implementation)."
 `;
 
 exports[`validate options unknown (pitch) 1`] = `
-"Invalid options object. Cache Loader (Pitch) has been initialised using an options object that does not match the API schema.
+"Invalid options object. Cache Loader (Pitch) has been initialized using an options object that does not match the API schema.
  - options has an unknown property 'unknown'. These properties are valid:
    object { cacheAddedFiles?, cacheContext?, cacheKey?, cacheIdentifier?, cacheDirectory?, compare?, precision?, read?, readOnly?, write? }"
 `;
 
 exports[`validate options unknown 1`] = `
-"Invalid options object. Cache Loader has been initialised using an options object that does not match the API schema.
+"Invalid options object. Cache Loader has been initialized using an options object that does not match the API schema.
  - options has an unknown property 'unknown'. These properties are valid:
    object { cacheAddedFiles?, cacheContext?, cacheKey?, cacheIdentifier?, cacheDirectory?, compare?, precision?, read?, readOnly?, write? }"
 `;