Skip to content

Commit e357925

Browse files
committed
fix: rename scale to scaleFactor in Device type
1 parent 441d3c5 commit e357925

File tree

6 files changed

+8
-8
lines changed

6 files changed

+8
-8
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ const device: Device = {
3838
name: "iPhone 12 Pro",
3939
width: 390,
4040
height: 844,
41-
scale: 3,
41+
scaleFactor: 3,
4242
ppi: 460,
4343
};
4444

examples/visualization.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const device: Device = {
1313
name: "iPhone 12 Pro",
1414
width: 390,
1515
height: 844,
16-
scale: 3,
16+
scaleFactor: 3,
1717
ppi: 460,
1818
};
1919

src/adapters/puppeteer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export class PuppeteerAdapter implements Adapter {
2323
await this.page.setViewport({
2424
width: device.width,
2525
height: device.height,
26-
deviceScaleFactor: device.scale,
26+
deviceScaleFactor: device.scaleFactor,
2727
});
2828
await this.page.goto(url);
2929
await this.page.evaluate(async () => {

src/tappy.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ export class Tappy {
1717
const html = await this.adapter.getHtml();
1818

1919
const resultElements = elements.map((element) => {
20-
const mmWidth = pixelToMm(element.width, device.ppi, device.scale);
21-
const mmHeight = pixelToMm(element.height, device.ppi, device.scale);
20+
const mmWidth = pixelToMm(element.width, device.ppi, device.scaleFactor);
21+
const mmHeight = pixelToMm(element.height, device.ppi, device.scaleFactor);
2222
const sigmaX = Math.sqrt(0.0091 * mmWidth ** 2 + 1.0949);
2323
const sigmaY = Math.sqrt(0.0149 * mmHeight ** 2 + 0.9414);
2424
const tapSuccessRate =

src/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export type Device = {
2525
/**
2626
* The scale factor of the device.
2727
*/
28-
scale: number;
28+
scaleFactor: number;
2929
};
3030

3131
/**

test/tappy.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ describe("Tappy", () => {
99
name: "MockDevice",
1010
width: 800,
1111
height: 600,
12-
scale: 2,
12+
scaleFactor: 2,
1313
ppi: 96,
1414
};
1515

@@ -63,7 +63,7 @@ describe("Tappy", () => {
6363
name: "MockDevice",
6464
width: 800,
6565
height: 600,
66-
scale: 2,
66+
scaleFactor: 2,
6767
ppi: 96,
6868
};
6969

0 commit comments

Comments
 (0)