actions: Add dialog to markNarrowAsRead for CombinedFeedNarrow view

chungwwei · chungwwei · commit 970aee6359ad · 2025-12-02T16:18:29.000-05:00
A confirm ActionDialog is added to prevent accidentally marking many messages as read in CombinedFeedNarrow view Also, adjust existing MarkAsReadWidget tests to account for the added confirmation dialog. Fixes: part of #1858
diff --git a/assets/l10n/app_en.arb b/assets/l10n/app_en.arb
@@ -932,6 +932,18 @@
   "@errorMarkAsUnreadFailedTitle": {
     "description": "Error title when mark as unread action failed."
   },
+  "markAllAsReadConfirmationDialogTitle": "Mark all messages as read?",
+  "@markAllAsReadConfirmationDialogTitle": {
+    "description": "Title of the confirmation dialog for marking all messages as read"
+  },
+  "markAllAsReadConfirmationDialogMessage": "You are not in a conversation view. Marking all as read may unintentionally mark unseen messages as read. Do you want to continue?",
+  "@markAllAsReadConfirmationDialogMessage": {
+    "description": "Message that warns the user they may unintentionally mark messages as read"
+  },
+  "markAllAsReadConfirmationDialogAction": "Yes, mark as read",
+  "@markAllAsReadConfirmationDialogAction": {
+    "description": "Action message to confirm marking all messages as read."
+  },
   "today": "Today",
   "@today": {
     "description": "Term to use to reference the current day."
diff --git a/lib/generated/l10n/zulip_localizations.dart b/lib/generated/l10n/zulip_localizations.dart
@@ -1387,6 +1387,24 @@ abstract class ZulipLocalizations {
   /// **'Mark as unread failed'**
   String get errorMarkAsUnreadFailedTitle;
 
+  /// Title of the confirmation dialog for marking all messages as read
+  ///
+  /// In en, this message translates to:
+  /// **'Mark all messages as read?'**
+  String get markAllAsReadConfirmationDialogTitle;
+
+  /// Message that warns the user they may unintentionally mark messages as read
+  ///
+  /// In en, this message translates to:
+  /// **'You are not in a conversation view. Marking all as read may unintentionally mark unseen messages as read. Do you want to continue?'**
+  String get markAllAsReadConfirmationDialogMessage;
+
+  /// Action message to confirm marking all messages as read.
+  ///
+  /// In en, this message translates to:
+  /// **'Yes, mark as read'**
+  String get markAllAsReadConfirmationDialogAction;
+
   /// Term to use to reference the current day.
   ///
   /// In en, this message translates to:
diff --git a/lib/generated/l10n/zulip_localizations_ar.dart b/lib/generated/l10n/zulip_localizations_ar.dart
@@ -774,6 +774,17 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
   @override
   String get errorMarkAsUnreadFailedTitle => 'Mark as unread failed';
 
+  @override
+  String get markAllAsReadConfirmationDialogTitle =>
+      'Mark all messages as read?';
+
+  @override
+  String get markAllAsReadConfirmationDialogMessage =>
+      'You are not in a conversation view. Marking all as read may unintentionally mark unseen messages as read. Do you want to continue?';
+
+  @override
+  String get markAllAsReadConfirmationDialogAction => 'Yes, mark as read';
+
   @override
   String get today => 'Today';
 
diff --git a/lib/generated/l10n/zulip_localizations_de.dart b/lib/generated/l10n/zulip_localizations_de.dart
@@ -793,6 +793,17 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
   String get errorMarkAsUnreadFailedTitle =>
       'Als ungelesen markieren fehlgeschlagen';
 
+  @override
+  String get markAllAsReadConfirmationDialogTitle =>
+      'Mark all messages as read?';
+
+  @override
+  String get markAllAsReadConfirmationDialogMessage =>
+      'You are not in a conversation view. Marking all as read may unintentionally mark unseen messages as read. Do you want to continue?';
+
+  @override
+  String get markAllAsReadConfirmationDialogAction => 'Yes, mark as read';
+
   @override
   String get today => 'Heute';
 
diff --git a/lib/generated/l10n/zulip_localizations_el.dart b/lib/generated/l10n/zulip_localizations_el.dart
@@ -774,6 +774,17 @@ class ZulipLocalizationsEl extends ZulipLocalizations {
   @override
   String get errorMarkAsUnreadFailedTitle => 'Mark as unread failed';
 
+  @override
+  String get markAllAsReadConfirmationDialogTitle =>
+      'Mark all messages as read?';
+
+  @override
+  String get markAllAsReadConfirmationDialogMessage =>
+      'You are not in a conversation view. Marking all as read may unintentionally mark unseen messages as read. Do you want to continue?';
+
+  @override
+  String get markAllAsReadConfirmationDialogAction => 'Yes, mark as read';
+
   @override
   String get today => 'Today';
 
diff --git a/lib/generated/l10n/zulip_localizations_en.dart b/lib/generated/l10n/zulip_localizations_en.dart
@@ -774,6 +774,17 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
   @override
   String get errorMarkAsUnreadFailedTitle => 'Mark as unread failed';
 
+  @override
+  String get markAllAsReadConfirmationDialogTitle =>
+      'Mark all messages as read?';
+
+  @override
+  String get markAllAsReadConfirmationDialogMessage =>
+      'You are not in a conversation view. Marking all as read may unintentionally mark unseen messages as read. Do you want to continue?';
+
+  @override
+  String get markAllAsReadConfirmationDialogAction => 'Yes, mark as read';
+
   @override
   String get today => 'Today';
 
diff --git a/lib/generated/l10n/zulip_localizations_es.dart b/lib/generated/l10n/zulip_localizations_es.dart
@@ -774,6 +774,17 @@ class ZulipLocalizationsEs extends ZulipLocalizations {
   @override
   String get errorMarkAsUnreadFailedTitle => 'Mark as unread failed';
 
+  @override
+  String get markAllAsReadConfirmationDialogTitle =>
+      'Mark all messages as read?';
+
+  @override
+  String get markAllAsReadConfirmationDialogMessage =>
+      'You are not in a conversation view. Marking all as read may unintentionally mark unseen messages as read. Do you want to continue?';
+
+  @override
+  String get markAllAsReadConfirmationDialogAction => 'Yes, mark as read';
+
   @override
   String get today => 'Today';
 
diff --git a/lib/generated/l10n/zulip_localizations_fr.dart b/lib/generated/l10n/zulip_localizations_fr.dart
@@ -790,6 +790,17 @@ class ZulipLocalizationsFr extends ZulipLocalizations {
   @override
   String get errorMarkAsUnreadFailedTitle => 'Mark as unread failed';
 
+  @override
+  String get markAllAsReadConfirmationDialogTitle =>
+      'Mark all messages as read?';
+
+  @override
+  String get markAllAsReadConfirmationDialogMessage =>
+      'You are not in a conversation view. Marking all as read may unintentionally mark unseen messages as read. Do you want to continue?';
+
+  @override
+  String get markAllAsReadConfirmationDialogAction => 'Yes, mark as read';
+
   @override
   String get today => 'Today';
 
diff --git a/lib/generated/l10n/zulip_localizations_he.dart b/lib/generated/l10n/zulip_localizations_he.dart
@@ -774,6 +774,17 @@ class ZulipLocalizationsHe extends ZulipLocalizations {
   @override
   String get errorMarkAsUnreadFailedTitle => 'Mark as unread failed';
 
+  @override
+  String get markAllAsReadConfirmationDialogTitle =>
+      'Mark all messages as read?';
+
+  @override
+  String get markAllAsReadConfirmationDialogMessage =>
+      'You are not in a conversation view. Marking all as read may unintentionally mark unseen messages as read. Do you want to continue?';
+
+  @override
+  String get markAllAsReadConfirmationDialogAction => 'Yes, mark as read';
+
   @override
   String get today => 'Today';
 
diff --git a/lib/generated/l10n/zulip_localizations_hu.dart b/lib/generated/l10n/zulip_localizations_hu.dart
@@ -774,6 +774,17 @@ class ZulipLocalizationsHu extends ZulipLocalizations {
   @override
   String get errorMarkAsUnreadFailedTitle => 'Mark as unread failed';
 
+  @override
+  String get markAllAsReadConfirmationDialogTitle =>
+      'Mark all messages as read?';
+
+  @override
+  String get markAllAsReadConfirmationDialogMessage =>
+      'You are not in a conversation view. Marking all as read may unintentionally mark unseen messages as read. Do you want to continue?';
+
+  @override
+  String get markAllAsReadConfirmationDialogAction => 'Yes, mark as read';
+
   @override
   String get today => 'Today';
 
diff --git a/lib/generated/l10n/zulip_localizations_it.dart b/lib/generated/l10n/zulip_localizations_it.dart
@@ -785,6 +785,17 @@ class ZulipLocalizationsIt extends ZulipLocalizations {
   String get errorMarkAsUnreadFailedTitle =>
       'Contrassegno come non letti non riuscito';
 
+  @override
+  String get markAllAsReadConfirmationDialogTitle =>
+      'Mark all messages as read?';
+
+  @override
+  String get markAllAsReadConfirmationDialogMessage =>
+      'You are not in a conversation view. Marking all as read may unintentionally mark unseen messages as read. Do you want to continue?';
+
+  @override
+  String get markAllAsReadConfirmationDialogAction => 'Yes, mark as read';
+
   @override
   String get today => 'Oggi';
 
diff --git a/lib/generated/l10n/zulip_localizations_ja.dart b/lib/generated/l10n/zulip_localizations_ja.dart
@@ -752,6 +752,17 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
   @override
   String get errorMarkAsUnreadFailedTitle => '未読にできませんでした';
 
+  @override
+  String get markAllAsReadConfirmationDialogTitle =>
+      'Mark all messages as read?';
+
+  @override
+  String get markAllAsReadConfirmationDialogMessage =>
+      'You are not in a conversation view. Marking all as read may unintentionally mark unseen messages as read. Do you want to continue?';
+
+  @override
+  String get markAllAsReadConfirmationDialogAction => 'Yes, mark as read';
+
   @override
   String get today => '今日';
 
diff --git a/lib/generated/l10n/zulip_localizations_nb.dart b/lib/generated/l10n/zulip_localizations_nb.dart
@@ -774,6 +774,17 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
   @override
   String get errorMarkAsUnreadFailedTitle => 'Mark as unread failed';
 
+  @override
+  String get markAllAsReadConfirmationDialogTitle =>
+      'Mark all messages as read?';
+
+  @override
+  String get markAllAsReadConfirmationDialogMessage =>
+      'You are not in a conversation view. Marking all as read may unintentionally mark unseen messages as read. Do you want to continue?';
+
+  @override
+  String get markAllAsReadConfirmationDialogAction => 'Yes, mark as read';
+
   @override
   String get today => 'Today';
 
diff --git a/lib/generated/l10n/zulip_localizations_pl.dart b/lib/generated/l10n/zulip_localizations_pl.dart
@@ -790,6 +790,17 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
   String get errorMarkAsUnreadFailedTitle =>
       'Oznaczanie jako nieprzeczytane bez powodzenia';
 
+  @override
+  String get markAllAsReadConfirmationDialogTitle =>
+      'Mark all messages as read?';
+
+  @override
+  String get markAllAsReadConfirmationDialogMessage =>
+      'You are not in a conversation view. Marking all as read may unintentionally mark unseen messages as read. Do you want to continue?';
+
+  @override
+  String get markAllAsReadConfirmationDialogAction => 'Yes, mark as read';
+
   @override
   String get today => 'Dzisiaj';
 
diff --git a/lib/generated/l10n/zulip_localizations_ru.dart b/lib/generated/l10n/zulip_localizations_ru.dart
@@ -795,6 +795,17 @@ class ZulipLocalizationsRu extends ZulipLocalizations {
   String get errorMarkAsUnreadFailedTitle =>
       'Не удалось снять отметку прочтения';
 
+  @override
+  String get markAllAsReadConfirmationDialogTitle =>
+      'Mark all messages as read?';
+
+  @override
+  String get markAllAsReadConfirmationDialogMessage =>
+      'You are not in a conversation view. Marking all as read may unintentionally mark unseen messages as read. Do you want to continue?';
+
+  @override
+  String get markAllAsReadConfirmationDialogAction => 'Yes, mark as read';
+
   @override
   String get today => 'Сегодня';
 
diff --git a/lib/generated/l10n/zulip_localizations_sk.dart b/lib/generated/l10n/zulip_localizations_sk.dart
@@ -776,6 +776,17 @@ class ZulipLocalizationsSk extends ZulipLocalizations {
   String get errorMarkAsUnreadFailedTitle =>
       'Zlyhalo označenie správ za prečítané';
 
+  @override
+  String get markAllAsReadConfirmationDialogTitle =>
+      'Mark all messages as read?';
+
+  @override
+  String get markAllAsReadConfirmationDialogMessage =>
+      'You are not in a conversation view. Marking all as read may unintentionally mark unseen messages as read. Do you want to continue?';
+
+  @override
+  String get markAllAsReadConfirmationDialogAction => 'Yes, mark as read';
+
   @override
   String get today => 'Dnes';
 
diff --git a/lib/generated/l10n/zulip_localizations_sl.dart b/lib/generated/l10n/zulip_localizations_sl.dart
@@ -804,6 +804,17 @@ class ZulipLocalizationsSl extends ZulipLocalizations {
   String get errorMarkAsUnreadFailedTitle =>
       'Označevanje kot neprebrano ni uspelo';
 
+  @override
+  String get markAllAsReadConfirmationDialogTitle =>
+      'Mark all messages as read?';
+
+  @override
+  String get markAllAsReadConfirmationDialogMessage =>
+      'You are not in a conversation view. Marking all as read may unintentionally mark unseen messages as read. Do you want to continue?';
+
+  @override
+  String get markAllAsReadConfirmationDialogAction => 'Yes, mark as read';
+
   @override
   String get today => 'Danes';
 
diff --git a/lib/generated/l10n/zulip_localizations_uk.dart b/lib/generated/l10n/zulip_localizations_uk.dart
@@ -791,6 +791,17 @@ class ZulipLocalizationsUk extends ZulipLocalizations {
   String get errorMarkAsUnreadFailedTitle =>
       'Не вдалося позначити як непрочитане';
 
+  @override
+  String get markAllAsReadConfirmationDialogTitle =>
+      'Mark all messages as read?';
+
+  @override
+  String get markAllAsReadConfirmationDialogMessage =>
+      'You are not in a conversation view. Marking all as read may unintentionally mark unseen messages as read. Do you want to continue?';
+
+  @override
+  String get markAllAsReadConfirmationDialogAction => 'Yes, mark as read';
+
   @override
   String get today => 'Сьогодні';
 
diff --git a/lib/generated/l10n/zulip_localizations_zh.dart b/lib/generated/l10n/zulip_localizations_zh.dart
@@ -774,6 +774,17 @@ class ZulipLocalizationsZh extends ZulipLocalizations {
   @override
   String get errorMarkAsUnreadFailedTitle => 'Mark as unread failed';
 
+  @override
+  String get markAllAsReadConfirmationDialogTitle =>
+      'Mark all messages as read?';
+
+  @override
+  String get markAllAsReadConfirmationDialogMessage =>
+      'You are not in a conversation view. Marking all as read may unintentionally mark unseen messages as read. Do you want to continue?';
+
+  @override
+  String get markAllAsReadConfirmationDialogAction => 'Yes, mark as read';
+
   @override
   String get today => 'Today';
 
diff --git a/lib/widgets/actions.dart b/lib/widgets/actions.dart
@@ -32,6 +32,17 @@ abstract final class ZulipAction {
   static Future<void> markNarrowAsRead(BuildContext context, Narrow narrow) async {
     final zulipLocalizations = ZulipLocalizations.of(context);
 
+    if (narrow is CombinedFeedNarrow) {
+      final didConfirm = showSuggestedActionDialog(context: context,
+        title: zulipLocalizations.markAllAsReadConfirmationDialogTitle,
+        message: zulipLocalizations.markAllAsReadConfirmationDialogMessage,
+        actionButtonText: zulipLocalizations.markAllAsReadConfirmationDialogAction,
+      );
+
+      if (await didConfirm.result != true) return;
+      if (!context.mounted) return;
+    }
+
     final didPass = await updateMessageFlagsStartingFromAnchor(
       context: context,
       // Include `is:unread` in the narrow.  That has a database index, so
diff --git a/test/widgets/actions_test.dart b/test/widgets/actions_test.dart
diff --git a/test/widgets/message_list_test.dart b/test/widgets/message_list_test.dart
