Skip to content

Commit ebf699d

Browse files
MritunjayTiwari14gnprice
authored andcommitted
login: Clarify semantics of alternative-authentication-methods divider
Fixes #1961.
1 parent 8f46f0c commit ebf699d

20 files changed

+78
-16
lines changed

assets/l10n/app_en.arb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -832,6 +832,10 @@
832832
"@loginMethodDivider": {
833833
"description": "Text on the divider between the username/password form and the third-party login options. Uppercase (for languages with letter case)."
834834
},
835+
"loginMethodDividerSemanticLabel": "Log-in alternatives",
836+
"@loginMethodDividerSemanticLabel": {
837+
"description": "Semantic label for divider between the username/password form and the third-party login options."
838+
},
835839
"signInWithFoo": "Sign in with {method}",
836840
"@signInWithFoo": {
837841
"description": "Button to use {method} to sign in to the app.",

lib/generated/l10n/zulip_localizations.dart

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1269,6 +1269,12 @@ abstract class ZulipLocalizations {
12691269
/// **'OR'**
12701270
String get loginMethodDivider;
12711271

1272+
/// Semantic label for divider between the username/password form and the third-party login options.
1273+
///
1274+
/// In en, this message translates to:
1275+
/// **'Log-in alternatives'**
1276+
String get loginMethodDividerSemanticLabel;
1277+
12721278
/// Button to use {method} to sign in to the app.
12731279
///
12741280
/// In en, this message translates to:

lib/generated/l10n/zulip_localizations_ar.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -690,6 +690,9 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
690690
@override
691691
String get loginMethodDivider => 'OR';
692692

693+
@override
694+
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';
695+
693696
@override
694697
String signInWithFoo(String method) {
695698
return 'Sign in with $method';

lib/generated/l10n/zulip_localizations_de.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -709,6 +709,9 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
709709
@override
710710
String get loginMethodDivider => 'ODER';
711711

712+
@override
713+
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';
714+
712715
@override
713716
String signInWithFoo(String method) {
714717
return 'Anmelden mit $method';

lib/generated/l10n/zulip_localizations_el.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -690,6 +690,9 @@ class ZulipLocalizationsEl extends ZulipLocalizations {
690690
@override
691691
String get loginMethodDivider => 'OR';
692692

693+
@override
694+
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';
695+
693696
@override
694697
String signInWithFoo(String method) {
695698
return 'Sign in with $method';

lib/generated/l10n/zulip_localizations_en.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -690,6 +690,9 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
690690
@override
691691
String get loginMethodDivider => 'OR';
692692

693+
@override
694+
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';
695+
693696
@override
694697
String signInWithFoo(String method) {
695698
return 'Sign in with $method';

lib/generated/l10n/zulip_localizations_es.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -690,6 +690,9 @@ class ZulipLocalizationsEs extends ZulipLocalizations {
690690
@override
691691
String get loginMethodDivider => 'OR';
692692

693+
@override
694+
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';
695+
693696
@override
694697
String signInWithFoo(String method) {
695698
return 'Sign in with $method';

lib/generated/l10n/zulip_localizations_fr.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -706,6 +706,9 @@ class ZulipLocalizationsFr extends ZulipLocalizations {
706706
@override
707707
String get loginMethodDivider => 'OR';
708708

709+
@override
710+
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';
711+
709712
@override
710713
String signInWithFoo(String method) {
711714
return 'Sign in with $method';

lib/generated/l10n/zulip_localizations_he.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -690,6 +690,9 @@ class ZulipLocalizationsHe extends ZulipLocalizations {
690690
@override
691691
String get loginMethodDivider => 'OR';
692692

693+
@override
694+
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';
695+
693696
@override
694697
String signInWithFoo(String method) {
695698
return 'Sign in with $method';

lib/generated/l10n/zulip_localizations_hu.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -690,6 +690,9 @@ class ZulipLocalizationsHu extends ZulipLocalizations {
690690
@override
691691
String get loginMethodDivider => 'OR';
692692

693+
@override
694+
String get loginMethodDividerSemanticLabel => 'Log-in alternatives';
695+
693696
@override
694697
String signInWithFoo(String method) {
695698
return 'Sign in with $method';

0 commit comments

Comments
 (0)