(Potential FUTURE bug) wrong offset calculation #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pl752
changed the title
cincuranet
requested changes
Dec 16, 2025
| public void Write(byte[] buffer, int offset, int count) | ||
| { | ||
| for (var i = offset; i < count; i++) | ||
| for (int i = 0; i < count; i++) |
| public ValueTask WriteAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken = default) | ||
| { | ||
| for (var i = offset; i < count; i++) | ||
| for (int i = 0; i < count; i++) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think that was how you intended to calculate offset there (the i starts with offset and is then added with offset again, also it performs byte writing count-offset times, it didn't cause any troubles yet as the offset is always passed as 0 on all call sites)