Return not found when decodeURIComponent from params fail #3863
+28
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some requests are currently failing when receiving either invalid or spam requests for page params that include invalid characters.
Our current code to extract the params uses
decodeURIComponentwithout any safeguard, leading to crashing the whole Node process, which is even more problematic with fluid computing on Vercel.This PR prevents this problem by returning a 404 Not found on such requests on decoding errors.