Skip to content

Conversation

@vtjnash
Copy link
Contributor

@vtjnash vtjnash commented Dec 11, 2025

Previously the architecture-specific dynamic files were relying on the built-in rules alone.

Previously the architecture-specific dynamic files were relying on the
built-in rules alone.
@martin-frbg
Copy link
Collaborator

Sorry, I do not see what this would be fixing, when the built-in rule works fine (and has so for years)

@vtjnash
Copy link
Contributor Author

vtjnash commented Dec 15, 2025

I appreciate the quick review, but please reopen this. This was accidentally relying on an old-fashioned technique (not my name for it, literally that is what this feature is called https://www.gnu.org/software/make/manual/html_node/Suffix-Rules.html) that does not work reliably for many uses. In particular, the rule is only implemented when $(SUFFIX) is defined to be .o, but that means this one file breaks the build if any part of the Makefile uses a different SUFFIX value. This is a really simple fix for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants