Skip to content

feat(component): add Text Area component #3215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nilloq wants to merge 35 commits into
base: ouds/main
Choose a base branch
from
Open

feat(component): add Text Area component #3215

nilloq wants to merge 35 commits into from
+552 −108

Conversation

@nilloq
Copy link
Member

@nilloq nilloq commented Nov 10, 2025 •
edited
Loading

Types of change

  • Breaking change (fix or feature that would change existing functionality and usage)

Related issues

Closes #2919

Description

Implment new Text Area component

Checklists

  • I have read the contributing guidelines
  • My change follows the developer guide
  • My change pass all tests
  • My change is compatible with a responsive display
  • I have added tests (Javascript unit test or visual) to cover my changes
  • My change introduces changes to the documentation that I have updated accordingly
    • Title and DOM structure is correct
    • Links have been updated (title changes impact links)
    • CSS for the documentation
  • I have checked all states and combinations of the component with my change
  • I have checked all the impacts for the other components and core behavior (grid, reboot, utilities)

Checklist (for Core Team only)

  • The changes need to be in the migration guide
  • The changes are well displayed in Storybook (be careful if example order has changed for DSM)
  • The changes are compatible with RTL
  • Manually test browser compatibility with BrowserStack (Chrome 120, Firefox 121, Edge 120, Safari 15.6, iOS Safari, Chrome & Firefox on Android)

Progression (for Core Team only)

Live previews

@boosted-bot boosted-bot moved this from In Progress / Draft to Need Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Nov 10, 2025
@nilloq nilloq linked an issue Nov 10, 2025 that may be closed by this pull request
[OUDS] [Components] Create component - Text area #2919
Open
19 tasks
@netlify
Copy link

netlify bot commented Nov 10, 2025 •
edited
Loading

❌ Deploy Preview for boosted failed. Why did it fail? →

Name Link
🔨 Latest commit 36eafb7
🔍 Latest deploy log https://app.netlify.com/projects/boosted/deploys/693ae955b6dc040008d085d8

@nilloq nilloq requested a review from vprothais November 18, 2025 15:07
@louismaximepiton louismaximepiton self-requested a review November 20, 2025 13:14
louismaximepiton
louismaximepiton requested changes Nov 20, 2025
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General remarks:

  • The text-area scroll looks a bit broken on FF when it's little, I don't know if there is anything better to do here.
  • Wondering if the flash when we resize is questionable from a11y pov. I think we can avoid this anyway
  • We can probably do it later, but we might want a live example of the behavior of error text + helper text
  • We can probably do it later, but we might flatten the CSS to have less complexity in selectors
  • We can probably do it later, but I don't like having several places in one component that handles the same CSS var, I find hard to debug, but it's maybe only me on this.

TBH, I don't wanna go too deep in the review because it needs to land quite fast and it works well, but here are the implementation upgrades I could see so far.

scss/forms/_text-input.scss Outdated
box-shadow: none;

@supports (field-sizing: content) {
resize: none;
Copy link
Member

@louismaximepiton louismaximepiton Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reflection, maybe it's not a good pratice to remove functionality to people-, maybe they should have th eright to resize on every browser

Copy link
Member Author

@nilloq nilloq Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss it

scss/forms/_text-input.scss Outdated
}

// Invalid text inputs
&.was-validated:has(.text-area-field:invalid),
Copy link
Member

@louismaximepiton louismaximepiton Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .was-validated is not expected on the .text-area or any of its children but on the <form> element itself. I think it doesn't work in this case.

Copy link
Member Author

@nilloq nilloq Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be discussed if we keep .was-validated

@boosted-bot boosted-bot moved this from Need Dev Review to Dev Review In Progress in 🟣 [Orange-Boosted-Bootstrap] PRs Board Nov 20, 2025
louismaximepiton
louismaximepiton approved these changes Nov 24, 2025
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions to answer still, but it's good for me

@boosted-bot boosted-bot moved this from Dev Review In Progress to Need Lead Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Nov 24, 2025
MaxLardenois
MaxLardenois reviewed Nov 26, 2025
View reviewed changes
Copy link
Collaborator

@MaxLardenois MaxLardenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question I add while copying stuff for control items ;)

scss/forms/_text-input.scss Outdated
}

// Hover state styles
&:hover:has(.text-area-field:not(:focus):not(:disabled):not(:read-only):not(.is-invalid)) {
Copy link
Collaborator

@MaxLardenois MaxLardenois Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add a list in the :not() instead of repeating them (I know it wont make the selector small)

vprothais
vprothais requested changes Dec 5, 2025
View reviewed changes
@boosted-bot boosted-bot moved this from Need Lead Dev Review to Dev Review In Progress in 🟣 [Orange-Boosted-Bootstrap] PRs Board Dec 5, 2025
nilloq
nilloq commented Dec 8, 2025
View reviewed changes
Copy link
Member Author

@nilloq nilloq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates following @vprothais review

@nilloq nilloq requested a review from vprothais December 8, 2025 15:36
@boosted-bot boosted-bot moved this from Dev Review In Progress to Need Lead Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Dec 9, 2025
@vprothais
Copy link
Collaborator

vprothais commented Dec 9, 2025

Ok on technical side, can be merged when ok a11y and design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxLardenois MaxLardenois MaxLardenois left review comments

@vprothais vprothais vprothais approved these changes

@louismaximepiton louismaximepiton louismaximepiton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

🟣 [Orange-Boosted-Bootstrap] PRs Board
Status: Need Lead Dev Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[OUDS] [Components] Create component - Text area

4 participants

@nilloq @vprothais @louismaximepiton @MaxLardenois