Skip to content

Conversation

@vadyvas
Copy link
Contributor

@vadyvas vadyvas commented Nov 24, 2025

What/Why/How?

  • Update @redocly/ajv to the latest version
  • Sync our @redocly/ajv fork with upstream

Reference

Depends on Redocly/ajv#29

Testing

monorepo tests: https://github.com/Redocly/redocly/pull/19433

Screenshots (optional)

Check yourself

  • Code changed? - Tested with Redoc/Realm/Reunite (internal)
  • All new/updated code is covered by tests
  • New package installed? - Tested in different environments (browser/node)
  • Documentation update considered

Security

  • The security impact of the change has been considered
  • Code follows company security practices and guidelines

@vadyvas vadyvas added the snapshot Create experimental release PR label Nov 24, 2025
@changeset-bot
Copy link

changeset-bot bot commented Nov 24, 2025

🦋 Changeset detected

Latest commit: ae2ebbf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@redocly/openapi-core Patch
@redocly/respect-core Patch
@redocly/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

📦 A new experimental 🧪 version v0.0.0-snapshot.1764022528 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]

⚠️ Note: This is a development build and may contain unstable features.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

Command Mean [s] Min [s] Max [s] Relative
redocly lint resources/rebilly.yaml 1.490 ± 0.027 1.463 1.545 1.02 ± 0.03
redocly-next lint resources/rebilly.yaml 1.456 ± 0.033 1.419 1.520 1.00

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 78.74% (🎯 78%) 5857 / 7438
🟢 Statements 78.18% (🎯 78%) 6052 / 7741
🟢 Functions 81.88% (🎯 81%) 1202 / 1468
🟢 Branches 70.94% (🎯 70%) 4054 / 5714
File CoverageNo changed files found.
Generated in workflow #8037 for commit ae2ebbf by the Vitest Coverage Report Action

@vadyvas vadyvas marked this pull request as ready for review November 25, 2025 09:10
@vadyvas vadyvas requested review from a team as code owners November 25, 2025 09:10
@tatomyr
Copy link
Collaborator

tatomyr commented Nov 25, 2025

@vadyvas did it really get faster?
image

"@redocly/respect-core": patch
---

Updated `@redocly/ajv` to the `v8.17.1`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we use ajv-formats in respect core? I think we should. @DmitryAnansky, WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't use it at the moment.
Yes, we can try to add it to respect as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tatomyr should i add ajv-formats in this PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in this PR, but they have to be in sync.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created an issue: #2428

@vadyvas
Copy link
Contributor Author

vadyvas commented Nov 25, 2025

@vadyvas did it really get faster? image

@tatomyr With the rerun results, next is still a bit faster, but the difference is small and likely within measurement noise.
image

@vadyvas vadyvas force-pushed the chore/bump-ajv branch 2 times, most recently from 3c87248 to 1d8363f Compare November 25, 2025 14:13
@vadyvas vadyvas added snapshot Create experimental release PR and removed snapshot Create experimental release PR labels Nov 25, 2025
@github-actions
Copy link
Contributor

📦 A new experimental 🧪 version v0.0.0-snapshot.1764081686 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]

⚠️ Note: This is a development build and may contain unstable features.

@vadyvas vadyvas merged commit 4c8563b into main Nov 26, 2025
50 checks passed
@vadyvas vadyvas deleted the chore/bump-ajv branch November 26, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

snapshot Create experimental release PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants