Skip to content

Retry on HTTP 522 Connection timed out #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
findepi wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −9
Open

Retry on HTTP 522 Connection timed out #964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/setup/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129897,7 +129897,7 @@ class JavaBase {
// Check if error is retryable (including aggregate errors)
const isRetryable = (error instanceof tc.HTTPError &&
error.httpStatusCode &&
[429, 502, 503, 504].includes(error.httpStatusCode)) ||
[429, 502, 503, 504, 522].includes(error.httpStatusCode)) ||
retryableCodes.includes(error === null || error === void 0 ? void 0 : error.code) ||
((error === null || error === void 0 ? void 0 : error.errors) &&
Array.isArray(error.errors) &&
Expand Down
7 changes: 0 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/distributions/base-installer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export abstract class JavaBase {
const isRetryable =
(error instanceof tc.HTTPError &&
error.httpStatusCode &&
[429, 502, 503, 504].includes(error.httpStatusCode)) ||
[429, 502, 503, 504, 522].includes(error.httpStatusCode)) ||
Copy link

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of HTTP 522 to the retryable status codes is appropriate, but there's no test coverage for the retry logic with HTTP status codes. Consider adding tests to verify that HTTP 522 (and other retryable status codes like 502, 503, 504) trigger the retry mechanism correctly. This would help prevent regressions and document the expected behavior.

Copilot uses AI. Check for mistakes.
Copy link
Author

@findepi findepi Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there existing test that i should extend that covers existing retries?

retryableCodes.includes(error?.code) ||
(error?.errors &&
Array.isArray(error.errors) &&
Expand Down
Loading