Fix Textbox not working #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
approved these changes
Dec 9, 2025
Contributor
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
Thanks for the fix! Looks good to me.
adafruit-adabot
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 10, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 3.4.1 from 3.3.4: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#230 from makermelissa/main > Revert "Fix Textbox not working" > Fix Textbox not working > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#228 from FoamyGuy/combine_bitmap_label Updating https://github.com/adafruit/Adafruit_CircuitPython_USB_Host_Mouse to 1.6.1 from 1.6.0: > Merge pull request adafruit/Adafruit_CircuitPython_USB_Host_Mouse#15 from RetiredWizard/interfaceindx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #229.
The way super() was called, it was bypassing the bitmap_label init code.
Note: I accidentally committed directly to branch, but then reverted as it should be a PR.