Skip to content

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Dec 10, 2025

Motivation

https://github.com/google/error-prone is a useful library for finding bug patterns in source code.
The Pulsar build contains the errorprone profile for running the build with errorprone. The pom.xml contains inline comments how to use it.
For example, errorprone's FutureReturnValueIgnored check would find issues like #25051.

The errorprone version hasn't been upgraded for a while.

Modifications

  • upgrade errorprone version to 2.45.0

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.2.0 milestone Dec 10, 2025
@lhotari lhotari requested a review from Technoboy- December 10, 2025 08:43
@lhotari lhotari self-assigned this Dec 10, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 10, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.33%. Comparing base (89f6015) to head (e6bb6d5).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #25054       +/-   ##
=============================================
+ Coverage     38.64%   74.33%   +35.69%     
- Complexity    13341    34096    +20755     
=============================================
  Files          1864     1921       +57     
  Lines        146223   150387     +4164     
  Branches      16984    17470      +486     
=============================================
+ Hits          56506   111789    +55283     
+ Misses        82051    29674    -52377     
- Partials       7666     8924     +1258     
Flag Coverage Δ
inttests 26.30% <ø> (-0.14%) ⬇️
systests 22.79% <ø> (-0.11%) ⬇️
unittests 73.87% <ø> (+39.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1421 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari requested review from dao-jun and nodece December 10, 2025 10:30
@Technoboy- Technoboy- merged commit d2a45e7 into apache:master Dec 10, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants