GHA: test TODOs from earlier #102
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
via #94:
A bunch of ideas I did not implement in this PR:
redhat-actions/podman-loginaction withpodman logincommand for ghcr.io logins.They do the same, though our command invocation is a bit more secure.
The action logs out, which is a plus, though it's already not done for podman/docker acounts.
It'd allow dropping this actions dependencies and easier to replicate the logic locally.
github.actorwithgithub.repository_owner(=curl)? GH token works with both. [WORKS, but no advantages ATM, with a chance of breaking things, so SKIP.]sigstore/cosign-installeraction with Linuxbrew. not pinned, with its upsides and downsides.To allow dropping this actions dependencies and easier to replicate the logic locally.
With this removed the Settings / Actions / General exceptions could be deleted.
https://github.com/curl/curl-container/actions/runs/20120515214/job/57739492278