feat: show platform prefix in bake logs #414
Closed
+9
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When running
depot bakewith multiple targets on different platforms, the logs were like provided no platform info to help you figure out which arch was doing what.What was happening
Bake logs showed target names but not platforms:
Even though frontend was building on amd64 and backend on arm64!
What happens now
Bake now tells BuildKit to show platform prefixes:
Much easier to follow what's happening where. 🎯
Changes
bake.go: SetDEPOT_FORCE_PLATFORM_PREFIX=truebuild arg for all bake targetsbuild.go: Convert that build arg toforce-platform-prefixfrontend attributeTest plan
depot bake --progress=plainand verify platform prefixes showAnything else?
This depends on https://github.com/depot/buildkit-private/pull/37 being deployed first — the CLI sends the attribute, but builders need to understand it.
Closes DEP-2793