Skip to content
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Documentation/wpf.vsconfig
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"Microsoft.VisualStudio.Component.VC.Redist.14.Latest",
"Microsoft.VisualStudio.Component.VC.Tools.x86.x64",
"Microsoft.VisualStudio.Component.VSSDK",
"Microsoft.VisualStudio.Component.Windows10SDK.19041"
"Microsoft.VisualStudio.Component.Windows10SDK.19041",
"Microsoft.VisualStudio.Component.Windows11SDK.26100"
]
}
4 changes: 2 additions & 2 deletions azure-pipelines-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ stages:
# agent pool can't be read from a user-defined variable (Azure DevOps limitation)
${{ if eq(variables['System.TeamProject'], 'public') }}:
name: NetCore-Public
demands: ImageOverride -equals windows.vs2022.amd64.Open
demands: ImageOverride -equals windows.vs2026preview.scout.amd64.Open

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the only preview version available ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${{ if eq(variables['System.TeamProject'], 'internal') }}:
name: NetCore1ESPool-Internal
demands: ImageOverride -equals windows.vs2022.amd64
demands: ImageOverride -equals windows.vs2026preview.scout.amd64
variables:
- name: _Platform
value: x86
Expand Down
2 changes: 1 addition & 1 deletion azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,4 @@ extends:
binlogPath: artifacts/log/Debug/x86/Build.binlog
pool:
name: NetCore1ESPool-Internal
demands: ImageOverride -equals windows.vs2022.amd64
demands: ImageOverride -equals windows.vs2026preview.scout.amd64
4 changes: 2 additions & 2 deletions eng/WpfArcadeSdk/tools/Wpf.Cpp.props
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
<CharacterSet>Unicode</CharacterSet>

<!-- v143 = Visual Studio 2022 -->
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment still references Visual Studio 2022, but the toolset has been updated to v145 which corresponds to Visual Studio 2026. Please update the comment to reflect this change, e.g., <!-- v145 = Visual Studio 2026 -->

Suggested change
<!-- v143 = Visual Studio 2022 -->
<!-- v145 = Visual Studio 2026 -->

Copilot uses AI. Check for mistakes.
<PlatformToolset>v143</PlatformToolset>
<PlatformToolset>v145</PlatformToolset>

<!-- 17134 is Windows 10 v1903 (19H1) SDK -->
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is outdated and inaccurate. The SDK version 17134 corresponds to Windows 10 v1803 (April 2018 Update, not v1903), and the code now uses version 10.0.26100.0 which is the Windows 11 24H2 SDK. Please update the comment to accurately reflect the current SDK version, e.g., <!-- 26100 is Windows 11 24H2 SDK -->

Suggested change
<!-- 17134 is Windows 10 v1903 (19H1) SDK -->
<!-- 26100 is Windows 11 24H2 SDK -->

Copilot uses AI. Check for mistakes.
<WindowsTargetPlatformVersion>10.0.19041.0</WindowsTargetPlatformVersion>
<WindowsTargetPlatformVersion>10.0.26100.0</WindowsTargetPlatformVersion>

<ConfigurationType Condition="'$(ConfigurationType)'==''">DynamicLibrary</ConfigurationType>

Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.DotNet.Wpf/redist/VCRuntime/VCRuntime.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
<Import Project="$(WpfCppProps)" />
<PropertyGroup>
<VCRedistCrtFolderName Condition="'$(Configuration)'=='Release'">Microsoft.VC143.CRT</VCRedistCrtFolderName>
<VCRedistCrtFolderName Condition="'$(Configuration)'=='Debug'">Microsoft.VC143.DebugCRT</VCRedistCrtFolderName>
<VCRedistCrtFolderName Condition="'$(Configuration)'=='Release'">Microsoft.VC145.CRT</VCRedistCrtFolderName>
<VCRedistCrtFolderName Condition="'$(Configuration)'=='Debug'">Microsoft.VC145.DebugCRT</VCRedistCrtFolderName>
<!--
In Release builds, the Target assembly will be a privatized copy of VC runtime with a name like vcruntime140_cor3.dll
In Debug builds, the Target assembly will be a privatize copy of the VC runtime with no name changes - like vcruntime140d.dll
Expand Down
Loading