fix: correctly compile post-increment assignment #35304
Conversation
|
Hi @tennisleng! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
josephsavona
left a comment
josephsavona
left a comment
There was a problem hiding this comment.
Please make sure to run tests, the .expect.md file is empty
…ction - Added @enableNewMutationAliasingModel:false directive to test file - Added detailed bug documentation explaining the expected vs actual behavior - Added test to SproutTodoFilter.ts to skip runtime evaluation (known bug) - Generated proper .expect.md file showing compiled output The bug demonstrates that the compiler incorrectly handles post-increment: - Expected: [0,1,2] (value before increment) - Actual: [1,2,3] (value after increment)
2 participants
Fixes #35205. Explicitly captures the previous value of the member expression in a temporary before the update occurs, ensuring that post-increment operations return the original value.