Skip to content
This repository was archived by the owner on Jul 20, 2024. It is now read-only.

Conversation

@magicyoda
Copy link

@magicyoda magicyoda commented Nov 21, 2021

Support for external layer (e.g. Klayers)

Delete custom_layer source folder after layer creation

  • When using a "custom_layer", the script picks a source folder and create a layer out of it.
  • As the source folder has now been made available as a new customer layer, I added the deletion of this source folder in order to avoid code redundancy: "rm -rf ${INPUT_CUSTOM_LAYER_4_PATH}" on each custom_layer_X_path function.

Fix code for multiple functions

  • During my test, the multiple function code was not working properly. There was no "directory" named after the function in which the script shall enter. I removed therefore the "cd "${1}"" and "cd .." on function 'publish_function()'

Lower operation redundancy

  • The function "publish_function()" was finally completely removed so that the zip "code.zip" is only created and deleted once and not each time for each target function.

@magicyoda magicyoda changed the title Support for external layer (e.g. Klayers) + Fix code for multiple functions + Lower operation redundancy Support external layer + Delete source folder when using custom layer + Fix multiple functions + Lower redundancy Nov 21, 2021
@magicyoda
Copy link
Author

@seattleagainstslavery After reviewing your web scraper code, I realise that this Pull Request would break it because of how your "multiple function" structure was designed. It is therefore not recommended to perform this full pull request. Only first and second point could be interesting for you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant