Add pagination tests for TableAggregate with namespace and composite keys #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…keys This adds tests that validate pagination behavior for the exact scenario reported by a customer: - TableAggregate with namespace function - Composite sortKey: [-doc.totalPoints, doc._id] - pageSize=1 with order='asc' Tests verify: 1. paginate with pageSize=1 returns cursor when more items exist 2. paginate with pageSize=1 iterates through all items correctly 3. paginate with pageSize=10 returns all items at once 4. iter with namespace and composite keys works correctly Also adds B-tree level pagination tests to verify the core implementation. All tests pass on the current codebase, indicating the reported issue may be fixed in the current version or related to customer wrapper code. Co-Authored-By: Ian Macartney <[email protected]>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
commit: |
Contributor
Author
|
Closing due to inactivity for more than 7 days. Configure here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pagination tests for TableAggregate with namespace and composite keys
Summary
Adds comprehensive pagination tests to investigate a customer-reported issue where
paginate({ pageSize: 1 })returnedcontinueCursor: nulldespite 3 entries existing.The tests cover the exact scenario reported:
TableAggregatewithnamespace: (doc) => doc.monthKeysortKey: (doc) => [-doc.totalPoints, doc._id]pageSize: 1withorder: "asc"Finding: All tests pass on the current codebase. This suggests either:
boundToPositioninclusivity fix in 9b64e74)@convex-dev/aggregate{cursor, isDone}tocontinueCursorNote: The library returns
{page, cursor, isDone}- there is nocontinueCursorfield. The customer likely has wrapper code doing something likecontinueCursor = cursor || nullwhich would incorrectly return null ifcursoris an empty string.Review & Testing Checklist for Human
@convex-dev/aggregatethey're usingcontinueCursorexample/convex/aggregate.test.tshas a pre-existing failure related to@convex-dev/migrationspackage (unrelated to this PR)Notes
continueCursor = isDone ? null : cursorpattern