fix clippy warnings #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unit value let-bindings and assert_eq comparisons in tests. Use matches! macro instead of match expression in lexer.
Make error messages more user-friendly and actionable when version specifications are missing components (e.g., '0.34' instead of '0.34.0'). Before: 'missing patch version: 0.34' After: 'incomplete version: 0.34.x - versions must follow MAJOR.MINOR.PATCH format (e.g., 0.34.0)' Also added tests for range parsing with incomplete versions to ensure these error cases are properly covered. Addresses issue gleam-lang#35
lpil
reviewed
Nov 20, 2025
Member
lpil
left a comment
lpil
left a comment
There was a problem hiding this comment.
Thank you, I've left some notes in line
| fmt, | ||
| "incomplete version: {}.x.x - versions must follow MAJOR.MINOR.PATCH format (e.g., {}.0.0)", | ||
| major, major | ||
| ) |
Member
There was a problem hiding this comment.
These changes seem unrelated to clippy. Could you revert them please
| config.api_base = http::Uri::try_from(server.url()).unwrap(); | ||
|
|
||
| let result = crate::api_remove_docs_response( | ||
| crate::api_remove_docs_response( |
Member
There was a problem hiding this comment.
These tests no longer ensure the return type is unit. Add an annotation or similar to put back that test functionality please.
| assert!(error_msg.contains("incomplete version")); | ||
| assert!(error_msg.contains("1.x.x")); | ||
| assert!(error_msg.contains("1.0.0")); | ||
| } |
Member
There was a problem hiding this comment.
These seem unrelated to clippy, please remove them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unit value let-bindings and assert_eq comparisons in tests. Use matches! macro instead of match expression in lexer.