Skip to content

IWF-836: SDK expects stateWaitUntilFailed flag instead stateStartApiSucceeded #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samuel27m merged 1 commit into from
Jun 17, 2025
Merged

IWF-836: SDK expects stateWaitUntilFailed flag instead stateStartApiSucceeded #88

samuel27m merged 1 commit into from
Jun 17, 2025

Conversation

@samuel27m
Copy link
Member

@samuel27m samuel27m commented Jun 16, 2025

Description

⚠️ Breaking change, requires iWF server version >= 1.18.0
SDK expects stateWaitUntilFailed flag instead stateStartApiSucceeded

Checklist

  • Code compiles correctly
  • Tests for the changes have been added
  • All tests passing
  • This PR change is backwards-compatible
  • This PR CONTAINS a (planned) breaking change (it is NOT backwards-compatible)

Related Issue

Addressing, but not yet closing indeedeng/iwf#520, as we still need:

  • Add changes for all SDKs
  • Clean up old server fields (i.e. remove stateStartApiSucceeded field)

@samuel27m samuel27m requested a review from a team June 16, 2025 12:56
@samuel27m samuel27m merged commit b48c955 into main Jun 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lwolczynski lwolczynski lwolczynski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samuel27m @lwolczynski