Improve squash command description #8235
Open
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
The following commits do not follow our format for subject lines:
- 70c8b7f: Improve squash command description
Commits should have a subject line following the format <topic>: <description>. Please review the commit guidelines for more information.
steveklabnik
force-pushed
the
push-kuqtqyysnxou
branch
from
70c8b7f to
306a852
Compare
github-actions
bot
dismissed
their stale review
All commits are now correctly formatted. Thank you for your contribution!
joyously
reviewed
Dec 5, 2025
steveklabnik
force-pushed
the
push-kuqtqyysnxou
branch
2 times, most recently
from
826b788 to
76ecae5
Compare
martinvonz
reviewed
Dec 8, 2025
Add an explanation for why it's called "squash". Fixes jj-vcs#7661
steveklabnik
force-pushed
the
push-kuqtqyysnxou
branch
from
76ecae5 to
b76539e
Compare
martinvonz
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the one-line description to be clearer about what the command does, and add an explanation for why it's called "squash".
Fixes #7661
I'm fine with painting the bikeshed a different way, but here's my crack at it. After some consideration, I think trying to motivate "squash" while also describing what it does is too much, and so doing it this way might be best.