Add configurable confirmation dialog for "Close and Shut Down Notebook" #7784
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a configurable confirmation dialog when closing and shutting down a notebook, addressing issue #7398.
Changes
New schema file:
packages/notebook-extension/schema/close-tab.jsonconfirmClosingNotebookboolean setting (default:true)Updated
packages/notebook-extension/src/index.ts:showDialogimport from@jupyterlab/apputilsISettingRegistryas optional dependency tocloseTabpluginshowDialog()withDialog.warnButton()Updated
tsconfigbase.json:skipLibCheck: trueto bypass pre-existing lib0 type errorsTesting
Successfully tested with Playwright:
Context
Checklist
Note: This implementation respects both user preferences for warnings (default behavior) and those who prefer the NB6 behavior (no confirmation) by making it configurable through the settings system.