Add native JSON column type support for SQL Server 2025+ (Fixes #57965) #58105
+39
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Tests are failing. |
| $column = new \Illuminate\Support\Fluent(['name' => 'data', 'type' => 'json']); | ||
|
|
||
| // Assert that the Grammar returns the native JSON type. | ||
| $this->assertEquals('json', $grammar->typeJson($column)); |
Contributor
There was a problem hiding this comment.
Tests seem to be failing as the SqlServerGrammar@typeJson() method is protected and thus cannot be called here.
You can take a look on how the MySQL Schema Grammar is tested for the UUID fields (Illuminate\Tests\Database\DatabaseMySqlSchemaGrammarTest).
It tests against the Blueprint statements, which should suffice for this case too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57965
This PR implements version detection in SqlServerGrammar to utilize the native JSON datatype for SQL Server 2025+ while maintaining the nvarchar(max) fallback for older versions, as requested in the issue.