Refactor sync-ssh-keys.sh and users.conf for improved structure and f… #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctionality. Enhance error handling, add self-update feature, and streamline user key processing.
…e code readability. Update trap command syntax and clarify user key processing loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new configuration file,
users.conf, to support flexible and centralized SSH key management for thesync-ssh-keys.shscript. The file provides clear documentation and examples for specifying user SSH key sources, supporting multiple fetching methods, and optional GitHub token configuration.Configuration and documentation improvements:
users.confwith detailed comments explaining the configuration format, supported SSH key fetching methods (raw,api,ghuser), and GitHub token usage.USER_KEYSassociative array to demonstrate fetching keys from a public URL, a private GitHub repository, and a GitHub user profile.CONF_GITHUB_TOKENvariable for API access, with guidance on when it is required.…unctionality. Enhance error handling, add self-update feature, and streamline user key processing.