Fix schema for room forget call #2229
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://spec.matrix.org/v1.16/client-server-api/#post_matrixclientv3roomsroomidforget fails to define a request body. But it is not one of the four exceptions listed in https://spec.matrix.org/v1.16/client-server-api/#api-standards which deviate from the rule that > All POST and PUT endpoints, with the exception of those listed below, require the client to supply a request body containing a (potentially empty) JSON object.
anoadragon453
requested changes
Oct 27, 2025
Member
There was a problem hiding this comment.
Hi @harri-han, thanks for your PR!
Could you add both a sign-off and a changelog file please? This will allow us to accept your contribution. I think this would count as a "clarification" for the changelog entry.
As for the contents of the PR, I don't believe this requires an MSC as the spec already required that this endpoint must contain a JSON body (see the quoted text). It just wasn't clearly laid out in the OpenAPI spec. ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://spec.matrix.org/v1.16/client-server-api/#post_matrixclientv3roomsroomidforget fails to define a request body.
But it is not one of the four exceptions listed in https://spec.matrix.org/v1.16/client-server-api/#api-standards which deviate from the rule that
Pull Request Checklist
Preview: https://pr2229--matrix-spec-previews.netlify.app