Fix source generator for void-returning activity functions #554
+139
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source generator produced invalid C# code for activity functions returning
voidor non-genericTask, attempting to generateTask<void>which doesn't compile.Example of the issue:
Changes
ReturnsVoidflag detected viaSpecialType.System_Voidand non-genericTaskcomparison usingSymbolEqualityComparerTask(notTask<T>) for void activities, callingCallActivityAsyncwithout generic type parameterobjectparameters nullable viaSpecialTypecheck while preserving source nullability for other typesGenerated code after fix:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.