Don't re-run pytest when an exception in a test occurs #25588
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The general `except` around the pytest run was causing tests to run twice if the exception handling of pytest is disabled. From the comment in the code it seems the exception handling is only there for when reading the test IDs break, so it shouldn't be required around the pytest main call. Disabling the exception handling can be practical for debugging tests, as this starts up the python debugger within vscode. Currently however, this requires manually patching the run_pytest_script.py, which needs to be re-done every vscode update.
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where pytest tests would run twice when pytest's exception handling is disabled (typically for debugging purposes). The fix moves the pytest.main() call from inside the try block to an else block, ensuring that exceptions from pytest tests themselves don't trigger the fallback re-run mechanism.
Key Changes:
- Restructured the exception handling to use Python's try-except-else pattern
- The
pytest.main()call now executes only when test ID reading succeeds, not as part of the exception-prone code path
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eleanorjboyd
approved these changes
Dec 12, 2025
eleanorjboyd
added
the
bug
dmitrivMS
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The general
exceptaround the pytest run was causing tests to run twice if the exception handling of pytest is disabled. From the comment in the code it seems the exception handling is only there for when reading the test IDs break, so it shouldn't be required around the pytest main call.Disabling the exception handling can be practical for debugging tests, as this starts up the python debugger within vscode. Currently however, this requires manually patching the run_pytest_script.py, which needs to be re-done every vscode update.
fixes: #25656