Refactor schema validation to reduce duplication and add additionalProperties support #198
+240
−162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring extracts common schema validation logic into a base Schema class, eliminating ~100 lines of duplicate code between
InputSchemaandOutputSchema. It also adds support for the JSON SchemaadditionalPropertieskeyword to allow fine-grained control over extra properties in tool arguments.Previously
additionalParameterscould be set only onOutputSchema.Key changes:
Created
MCP::Tool::Schemabase class consolidating:Refactored
InputSchemato inherit fromSchema:Refactored
OutputSchemato inherit fromSchema:Updated Tool.input_schema setter:
Added
additionalPropertiessupport:additionalProperties: falseto disallow extrasBreaking Changes
InputSchema doesn't have
requiredandpropertiesreaders.Required params are now strings instead of symbols to match OutputSchema.
Before:
After:
Error messages are unified:
instead of
Impact: