Fix tool name collisions across namespaces #199
+28
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where only one tool could be registered when tools shared the same name, even if they were in different namespaces. With this change, tools in different namespaces can be registered as separate tools, so multiple tools with the same name can be registered. Fixes modelcontextprotocol#197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This fixes an issue where only one tool could be registered when tools shared the same name, even if they were in different namespaces. With this change, tools in different namespaces can be registered as separate tools, so multiple tools with the same name can be registered.
Fixes #197
How Has This Been Tested?
Regression and updating tests pass.
Breaking Changes
None.
Types of changes
Checklist