CLOUDP-351614 - Fix tls deactivation with monitoring #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCK 1.6.2 Release NotesBug Fixes
|
nammn
force-pushed
the
fix-tls-stopping
branch
from
ae774a7 to
9df6415
Compare
nammn
commented
Dec 17, 2025
| tags: [ "pr_patch", "staging", "e2e_test_suite", "static" ] | ||
| run_on: | ||
| - ubuntu2404-large | ||
| <<: *base_om8_dependency |
Collaborator
Author
There was a problem hiding this comment.
revert me once the image build has been fixed for the database image
When TLS is disabled on AppDB, the operator now correctly clears stale TLS parameters (additionalParams) from the monitoring configuration. Before this fix, stale TLS params like useSslForAllConnections and sslClientCertificate would remain in the monitoring config after TLS was disabled, causing monitoring agents to fail when trying to use certificate files that are no longer valid for authentication. Changes: - deployment.go: Clear additionalParams when TLS is disabled - appdbreplicaset_controller.go: Use correct TLS state for monitoring - Added e2e test (e2e_om_appdb_tls_disable) that verifies: 1. TLS params are present when TLS is enabled 2. TLS params are cleared after TLS is disabled 3. Monitoring continues to work after TLS disable
nammn
force-pushed
the
fix-tls-stopping
branch
from
9df6415 to
d6d52a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves the handling of TLS parameters in monitoring configuration, ensuring that TLS-related settings are properly cleared when TLS is disabled. It also adds a dedicated test to verify this behavior.
TLS Parameter Handling Improvements:
deployment.go, when TLS is disabled, the"additionalParams"key is now removed from the monitoring configuration to prevent monitoring agents from referencing non-existent certificate files.appdbreplicaset_controller.go, the code explicitly clears theAdditionalParamsfield for each monitoring version when TLS is disabled, further ensuring that leftover TLS settings are not retained.Testing Enhancements:
TestAddMonitoringTLSDisable, was added todeployment_test.goto verify that enabling and then disabling TLS correctly adds and then removes TLS parameters from the monitoring configuration.Proof of Work
Checklist
skip-changeloglabel if not needed