[ADD] estate: Add initial module structure with property model #1072
Conversation
…nifest. Created 'estate_property' model and fields.
|
|
|
Hello, can you please ensure that your runbot is green 😄 |
Also added access rights for estate.property model
lost-odoo
left a comment
lost-odoo
left a comment
There was a problem hiding this comment.
Hello, I already made a small review. Not a big deal but just some nitpicking stuff that we try to avoid. 😄
| _name = 'estate.property' | ||
| _description = 'Estate Property' | ||
|
|
||
| name = fields.Char('Property Name', required=True) |
There was a problem hiding this comment.
We use double quotes for strings that will be shown on the view. So instead of 'Property Name' it is better to do "Property Name".
| <menuitem id="estate_menu_properties" name="Properties" action="estate_property_action"/> | ||
| </menuitem> | ||
| </menuitem> | ||
| </odoo> No newline at end of file |
There was a problem hiding this comment.
Don't forget to always add a final new line 😄
| 'author': "Odoo", | ||
| 'website': "https://www.odoo.com", | ||
|
|
||
| # Categories can be used to filter modules in modules listing |
There was a problem hiding this comment.
You can remove those comments here and under from the manifest file.
| 'security/ir.model.access.csv', | ||
| ], | ||
| 'application': True, | ||
| 'installable': True, |
There was a problem hiding this comment.
By default when application is set, installable is set to true automatically.
| 'name': "Estate", | ||
|
|
||
| 'summary': """ | ||
| Starting module for "Estate" |
There was a problem hiding this comment.
I don't think Starting module for "Estate" in the summary and description are really appropriate here.
| <field name="res_model">estate.property</field> | ||
| <field name="view_mode">list,form</field> | ||
| </record> | ||
| </odoo> No newline at end of file |
|
Also please don't forget to make one commit per chapter. Try to make a correct title. Don't hesitate to amend or squash your commits. |
3 participants
Initialized Estate module and created 'estate_property' model.