Theta Forecaster #1309
Theta Forecaster #1309
Conversation
skjoracle
requested review from
VipulMascarenhas,
ahosler,
mayoor,
mrDzurb and
qiuosier
as code owners
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
the
OCA Required
oracle-contributor-agreement
bot
added
OCA Verified
|
📌 Cov diff with main: 📌 Overall coverage: |
1 similar comment
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
1 similar comment
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
prasankh
left a comment
prasankh
left a comment
There was a problem hiding this comment.
forecast operator tests are failing, let's fix those.
| source /home/runner/.bashrc | ||
| pip install -r test-requirements-operators.txt | ||
| pip install "oracle-automlx[forecasting]>=25.3.0" | ||
| pip install -U sktime |
There was a problem hiding this comment.
We need to add this to project.toml, not here.
| ) | ||
| ) | ||
| aggregate_local_explanations = pd.DataFrame() | ||
| for s_id, local_ex_df in self.local_explanation.items(): |
There was a problem hiding this comment.
Let's refactor to avoid duplicate code
|
|
||
| scoring = { | ||
| "mape": lambda y_true, y_pred: mean_absolute_percentage_error(y_true, y_pred), | ||
| "rmse": lambda y_true, y_pred: np.sqrt(mean_squared_error(y_true, y_pred)), |
There was a problem hiding this comment.
Let’s use the existing methods to calculate this. We can refactor them if needed.
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
2 participants
No description provided.