Skip to content

- Add langchain-oracle-js #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sudarshan12s wants to merge 16 commits into
base: main
Choose a base branch
from
Open

- Add langchain-oracle-js #73

sudarshan12s wants to merge 16 commits into from
+3,015 −0

Conversation

@sudarshan12s
Copy link
Member

@sudarshan12s sudarshan12s commented Nov 26, 2025 •
edited
Loading 

langchain-oracle/
│
├── libs/                
│   └── ... (existing code for python. This can be moved inside python?)
│   ├── js/oracledb/langchain-oracledb/
           |_____________________________ package.json
│          |_____________________________  src/
│          |_____________________________ tests/
│          |_____________________________tsconfig.json
│          |_____________________________ CONTRIBUTING.md    (optional)
│          |_____________________________ THIRD_PARTY_LICENSES.txt
│
├── .github/               (only ONE, at root)
│   ├── workflows/
│   │   ├── python-ci.yml
│   │   ├── js-ci.yml
│   │   └── lint.yml
│   ├── ISSUE_TEMPLATE/
│   ├── SECURITY.md
│   └── PULL_REQUEST_TEMPLATE.md
│
└── README.md              (explains the monorepo)

@oracle-contributor-agreement
Copy link

oracle-contributor-agreement bot commented Nov 26, 2025

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Nov 26, 2025
@YouNeedCryDear
Copy link
Member

YouNeedCryDear commented Nov 26, 2025 •
edited
Loading

I prefer keeping the python folder intact, then javascript living under js folder under the root directory.
Or entirely reorg as

libs/
  python/
    oci/
    oracledb/
  js/
    oracledb/

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Nov 27, 2025
@sudarshan12s
Copy link
Member Author

sudarshan12s commented Nov 27, 2025

I prefer keeping the python folder intact, then javascript living under js folder under the root directory. Or entirely reorg as

libs/
  python/
    oci/
    oracledb/
  js/
    oracledb/

Thanks.
I have created this structure for js, If we are ok with creating python folder, I can move current folders inside libs to libs/python

langchain-oracle/libs/js/oracledb/langchain-oracledb

sudarshan12s
sudarshan12s commented Dec 8, 2025
View reviewed changes
libs/js/oracledb/langchain-oracledb/README.md Outdated
@@ -0,0 +1,128 @@
# @langchain/cohere
Copy link
Member Author

@sudarshan12s sudarshan12s Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated to include installing langchain/oracle like npm install @langchain/oracle

@sudarshan12s sudarshan12s marked this pull request as ready for review December 8, 2025 13:52
@YouNeedCryDear
Copy link
Member

YouNeedCryDear commented Dec 17, 2025

@sudarshan12s Could you have another member from your team to review this PR?

sharadraju
sharadraju reviewed Dec 17, 2025
View reviewed changes
libs/js/oracledb/langchain-oracledb/package.json Outdated
{
"name": "@langchain/oracle",
"version": "0.3.1",
"description": "Oracle integration for LangChain.js",
Copy link
Member

@sharadraju sharadraju Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oracle Database integration for langchain.js

Copy link
Member Author

@sudarshan12s sudarshan12s Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

sharadraju
sharadraju reviewed Dec 17, 2025
View reviewed changes
libs/js/oracledb/langchain-oracledb/scripts/check-tree-shaking.js
}
}

if (failed) {
Copy link
Member

@sharadraju sharadraju Dec 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be simplified to just:

if (!failed)
  console.log("Tree shaking checks passed!");

Is process.exit(1) required?

Copy link
Member Author

@sudarshan12s sudarshan12s Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that error status 1 is needed else 0 is passed which comes as success.

Copy link
Member

@sharadraju sharadraju Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, if error status is required up the chain, then fine.

sharadraju
sharadraju reviewed Dec 18, 2025
View reviewed changes
libs/js/oracledb/langchain-oracledb/README.md

```json
{
"name": "your-project",
Copy link
Member

@sharadraju sharadraju Dec 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name should be updated here to probably "@langchain/oracle".

Copy link
Member Author

@sudarshan12s sudarshan12s Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name is application using @langchain/oracle, so its left that application.

Copy link
Member

@sharadraju sharadraju Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok. Got it

sharadraju
sharadraju reviewed Dec 18, 2025
View reviewed changes
libs/js/oracledb/langchain-oracledb/README.md Outdated
```json
{
"name": "your-project",
"version": "0.0.0",
Copy link
Member

@sharadraju sharadraju Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version number should be atleast 0.1.0

Copy link
Member Author

@sudarshan12s sudarshan12s Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

sharadraju
sharadraju approved these changes Dec 18, 2025
View reviewed changes
Copy link
Member

@sharadraju sharadraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sharadraju sharadraju sharadraju approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sudarshan12s @YouNeedCryDear @sharadraju @hackerdave