Skip to content

Conversation

@alexandear
Copy link
Contributor

What kind of change does this PR introduce?

This removes the workaround for the error wrapping in the cron/data package.

What is the current behavior?

Behaviour is not changed.

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #4636

Special notes for your reviewer

gocloud.dev has been upgraded by #4773

Does this PR introduce a user-facing change?

NONE

@alexandear alexandear requested a review from a team as a code owner November 28, 2025 15:46
@alexandear alexandear removed the request for review from a team November 28, 2025 15:46
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 28, 2025
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

This pull request has been marked stale because it has been open for 10 days with no activity

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.59%. Comparing base (353ed60) to head (6563ade).
⚠️ Report is 294 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4864      +/-   ##
==========================================
+ Coverage   66.80%   69.59%   +2.78%     
==========================================
  Files         230      251      +21     
  Lines       16602    15657     -945     
==========================================
- Hits        11091    10896     -195     
+ Misses       4808     3891     -917     
- Partials      703      870     +167     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I will try to keep an eye for when you rebase/ merge main, since the branch needs to be updated as maintainers dont have write access to your fork.

@alexandear
Copy link
Contributor Author

@spencerschrock rebased

@spencerschrock spencerschrock enabled auto-merge (squash) December 10, 2025 15:07
@alexandear alexandear deployed to integration-test December 11, 2025 00:25 — with GitHub Actions Active
@spencerschrock spencerschrock merged commit 094ab1d into ossf:main Dec 11, 2025
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Upgrade to go 1.24

2 participants