-
Notifications
You must be signed in to change notification settings - Fork 592
🌱 cron: remove error wrapping workaround #4864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8f454de to
f6a49cd
Compare
|
This pull request has been marked stale because it has been open for 10 days with no activity |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4864 +/- ##
==========================================
+ Coverage 66.80% 69.59% +2.78%
==========================================
Files 230 251 +21
Lines 16602 15657 -945
==========================================
- Hits 11091 10896 -195
+ Misses 4808 3891 -917
- Partials 703 870 +167 🚀 New features to boost your workflow:
|
spencerschrock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I will try to keep an eye for when you rebase/ merge main, since the branch needs to be updated as maintainers dont have write access to your fork.
Signed-off-by: Oleksandr Redko <[email protected]>
f6a49cd to
6563ade
Compare
|
@spencerschrock rebased |
What kind of change does this PR introduce?
This removes the workaround for the error wrapping in the
cron/datapackage.What is the current behavior?
Behaviour is not changed.
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Fixes #4636
Special notes for your reviewer
gocloud.devhas been upgraded by #4773Does this PR introduce a user-facing change?