Bugfix: v4.0.0rc3 feedback
#3532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Dash! 🎉 |
KoolADE85
force-pushed
the
bugfix/rc3-feedback
branch
from
fe13441 to
566107b
Compare
KoolADE85
commented
Dec 3, 2025
| const isEquivalent = (v1: number, v2: number) => | ||
| v1 === v2 || (isNaN(v1) && isNaN(v2)); | ||
|
|
||
| export enum HTMLInputTypes { |
Contributor
Author
There was a problem hiding this comment.
This is moved to types.ts
KoolADE85
commented
Dec 3, 2025
Comment on lines
-94
to
-97
| // eslint-disable-next-line no-magic-numbers | ||
| const HIDE_AT_WIDTH = value.length === 1 ? 200 : 250; | ||
| // eslint-disable-next-line no-magic-numbers | ||
| const SHOW_AT_WIDTH = value.length === 1 ? 300 : 450; |
Contributor
Author
There was a problem hiding this comment.
Hiding/showing is now done in CSS.
… do not support this natively)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of key fixes:
fixedtoabsolutepositioningautoComplete=falseindcc.Input.dcc.Inputwidth to be "100%" by default, which matches the other components.dcc.Tabs.Fixes https://github.com/plotly/ddk-dash-docs/issues/3605, #3531