Skip to content

Conversation

@edmundhung
Copy link

@edmundhung edmundhung commented Dec 9, 2025

RFC #14651

The diffs look huge but half of them are tests, as I am running the vite prerender tests with the new unstable flag as well to make sure both code paths work. The existing prerender logic is untouched. Happy to refactor if you would prefer consolidating them.

Feel free to review commit by commit. I have also added a /static route to the cloudflare playground as a working example.

Notes

  • This introduces a standalone prerender plugin after discussing with Jacob and Mark. The plugin supports automatic retry and redirect following, but they are not enabled at the moment. Happy to remove them to keep the scope smaller.
  • Added hasDefaultExport to route manifest to detect resource routes without loading server modules.
  • For SPA mode, we now write the SPA shell as __spa-fallback.html first and rename it to index.html after prerendering if the index page is not prerendered.
  • Since we are making real HTTP requests, passing loader data through headers might fail due to size limits. For routes with loader data larger than 8KB, we will omit the header and have the loader rerun again.

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2025

⚠️ No Changeset found

Latest commit: 12b9ca9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 9, 2025

Hi @edmundhung,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 9, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants