Skip to content

Conversation

@xonx4l
Copy link
Contributor

@xonx4l xonx4l commented Oct 28, 2025

In this PR Float tests are deduplicated and are unified in floats/mod.rs ,as discussed in #141726.

The moved float tests are-:

-> test_powf
-> test_exp
-> test_exp2
-> test_ln
-> test_log_generic
-> test_log2
-> test_log10
-> test_asinh
-> test_acosh
-> test_atanh
-> test_gamma
-> test_ln_gamma

r? tgross35

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2025

tgross35 is currently at their maximum review capacity.
They may take a while to respond.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@xonx4l xonx4l requested a review from bjorn3 November 4, 2025 00:43
@xonx4l
Copy link
Contributor Author

xonx4l commented Nov 11, 2025

Any update @bjorn3 ?

@bjorn3
Copy link
Member

bjorn3 commented Nov 11, 2025

CI is still failing.

@xonx4l
Copy link
Contributor Author

xonx4l commented Nov 11, 2025

CI is still failing.

ok let me fix .

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2025

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

@xonx4l xonx4l force-pushed the deduplicate-float-tests branch from b802b19 to abd73fd Compare November 14, 2025 08:43
@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

let inf: Float = Float::INFINITY;
let neg_inf: Float = Float::NEG_INFINITY;
assert_biteq!((10.0 as Float).log(10.0), 1.0);
assert_approx_eq!((2.3 as Float).log(3.5), 0.664858, Float::LOG_APPROX);
Copy link
Contributor

@LorrensP-2158466 LorrensP-2158466 Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test here for f128 will fail because the precision is much higher, if you look at the original test, the expected value is much more precise than what you have written:

assert_approx_eq!(2.3f128.log(3.5), 0.66485771361478710036766645911922010272, TOL);

When testing higher precision floats, you need much more precise expected values or the tests will fail, as they do now. In Miri, this is even more strict.

If you look at the source of f16 constants, they use much more digits after the decimal point than needed:

pub const PI: f16 = 3.14159265358979323846264338327950288_f16;

So you should probably do that as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay it makes sense . Thanks

@tgross35
Copy link
Contributor

Thank you for the final cleanup here. Until CI is fixed,
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@xonx4l
Copy link
Contributor Author

xonx4l commented Nov 19, 2025

Thank you for the final cleanup here. Until CI is fixed, @rustbot author

Will finish this as soon as possible . A bit busy these days.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer
Copy link
Collaborator

The job pr-check-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants