Skip to content

Remove unused code in cfg_old #149903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JonathanBrouwer wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove unused code in cfg_old #149903

JonathanBrouwer wants to merge 3 commits into from

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Dec 12, 2025 •
edited
Loading

r? @jdonszelmann

Fixes one of the todos from #149865

@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2025

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 12, 2025
@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 12, 2025
Open
11 tasks
@jdonszelmann
Copy link
Contributor

jdonszelmann commented Dec 12, 2025

this is awesome work! thanks :) Finally getting rid of some old attr code

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 12, 2025

📌 Commit acea7df has been approved by jdonszelmann

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 12, 2025
@matthiaskrgr
Rollup merge of rust-lang#149903 - JonathanBrouwer:cfg_old_cleanup, r…
c407072 
…=jdonszelmann

Remove unused code in `cfg_old`

r? `@jdonszelmann`

Fixes one of the todos from rust-lang#149865
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 12, 2025
Closed
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Dec 12, 2025

@bors r-
#149905 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 12, 2025
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Dec 12, 2025

@bors try job=aarch64-gnu-llvm-20-2

@rust-bors
Copy link

rust-bors bot commented Dec 12, 2025

Unknown argument "job". Run @bors2 help to see available commands.

@matthiaskrgr
Copy link
Member

matthiaskrgr commented Dec 12, 2025

@bors2 try jobs=aarch64-gnu-llvm-20-2

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Dec 12, 2025
@rust-bors
Auto merge of #149903 - JonathanBrouwer:cfg_old_cleanup, r=<try>
ea469cb 
Remove unused code in `cfg_old`

try-job: aarch64-gnu-llvm-20-2
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Dec 12, 2025

💔 Test for ea469cb failed: CI. Failed jobs:

@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Dec 12, 2025

@bors2 try jobs=aarch64-gnu-llvm-20-2

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Dec 12, 2025
@rust-bors
Auto merge of #149903 - JonathanBrouwer:cfg_old_cleanup, r=<try>
44d7933 
Remove unused code in `cfg_old`

try-job: aarch64-gnu-llvm-20-2
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Dec 12, 2025

Why did PR ci not catch that failure btw?

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Dec 12, 2025

💔 Test for 44d7933 failed: CI. Failed jobs:

@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Dec 12, 2025

@bors2 try jobs=aarch64-gnu-llvm-20-2

rust-bors bot added a commit that referenced this pull request Dec 12, 2025
@rust-bors
Auto merge of #149903 - JonathanBrouwer:cfg_old_cleanup, r=<try>
7a2c5b2 
Remove unused code in `cfg_old`

try-job: aarch64-gnu-llvm-20-2
@rust-bors

This comment has been minimized.

Sign in to view
@jdonszelmann
Copy link
Contributor

jdonszelmann commented Dec 12, 2025

r=me on ci pass

@rust-bors
Copy link

rust-bors bot commented Dec 12, 2025

☀️ Try build successful (CI)
Build commit: 7a2c5b2 (7a2c5b2897694cce7c330fc377245182dbc4316a, parent: 2a3a62d26e9e5badb806ac6a43bb307ff472b514)

@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Dec 12, 2025

@bors r=jdonszelmann rollup

@bors
Copy link
Collaborator

bors commented Dec 12, 2025

📌 Commit 0ab4b8b has been approved by jdonszelmann

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jdonszelmann jdonszelmann

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JonathanBrouwer @rustbot @jdonszelmann @bors @matthiaskrgr @rust-log-analyzer